Skip to content

feat: add DataVis NITRO condensed view overrides#234

Merged
garrity-miepub merged 1 commit into
mainfrom
feature/datavis-condensed-view-support
May 18, 2026
Merged

feat: add DataVis NITRO condensed view overrides#234
garrity-miepub merged 1 commit into
mainfrom
feature/datavis-condensed-view-support

Conversation

@garrity-miepub
Copy link
Copy Markdown
Contributor

  • Reduce table header height (38px → 24px)
  • Compact data rows (45px → 39px)
  • Tighter title bar, footer, control panel, filter bar
  • Smaller field pills, toolbar buttons, group headers
  • Affects all DataVis grids when body.condensed is active
image

- Reduce table header height (38px → 24px)
- Compact data rows (45px → 39px)
- Tighter title bar, footer, control panel, filter bar
- Smaller field pills, toolbar buttons, group headers
- Affects all DataVis grids when body.condensed is active
Copilot AI review requested due to automatic review settings May 18, 2026 20:32
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 030b533
Status: ✅  Deploy successful!
Preview URL: https://6baa4fde.ui-6d0.pages.dev
Branch Preview URL: https://feature-datavis-condensed-vi.ui-6d0.pages.dev

View logs

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds condensed-mode CSS overrides for DataVis NITRO grids to increase data density when body.condensed is active.

Changes:

  • Introduces a new “DataVis NITRO — Condensed Overrides” section in condensed-view.css.
  • Reduces padding/font sizes across DataVis grid areas (title bar, headers, rows/cells, footers, control/filter bars, toolbar, pills, group headers).
Comments suppressed due to low confidence (2)

src/styles/condensed-view.css:11543

  • wcdv-field-pill appears to be a control (sort/group pill). With the current condensed padding/font-size, its rendered height may drop below the WCAG 2.2 24×24 minimum target size for pointer inputs. If these pills are clickable/draggable controls, add a minimum height (and optionally min-width) to preserve an adequate hit area in condensed mode.
body.condensed .wcdv-field-pill {
  padding: 2px 6px !important;
  font-size: 0.6875rem !important;
  border-radius: 3px !important;
  gap: 0.125rem !important;
}

src/styles/condensed-view.css:11559

  • Condensed toolbar buttons are reduced to very small padding without an explicit line-height/min-height. This can create sub-24px click targets and make keyboard/pointer interaction harder. Consider adding a min-height (and possibly min-width) of 24px for .wcdv-toolbar button in condensed mode while keeping the visual density.
body.condensed .wcdv-toolbar button {
  padding: 2px 6px !important;
  font-size: 0.6875rem !important;
}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/styles/condensed-view.css
@garrity-miepub garrity-miepub marked this pull request as ready for review May 18, 2026 20:49
@garrity-miepub garrity-miepub merged commit 68aaea7 into main May 18, 2026
13 of 14 checks passed
@garrity-miepub garrity-miepub deleted the feature/datavis-condensed-view-support branch May 18, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants