Skip to content

WIP: Convert CV2 <-> CV1#85

Open
Rahzael wants to merge 25 commits into
midi2-dev:developfrom
Rahzael:develop
Open

WIP: Convert CV2 <-> CV1#85
Rahzael wants to merge 25 commits into
midi2-dev:developfrom
Rahzael:develop

Conversation

@Rahzael
Copy link
Copy Markdown

@Rahzael Rahzael commented Jan 17, 2026

A work in progress attempt to implement appendix D of the Midi 2.0 spec that allows for automatic conversion between specific MIDI 2.0 and 1.0 messages.

See #16 for details.

@Rahzael Rahzael mentioned this pull request Jan 17, 2026
Comment thread .gitignore
Comment thread flake.nix Outdated
Comment thread midi2/src/channel_voice2/note_on.rs Outdated
Comment thread midi2/src/channel_voice2/note_on.rs Outdated
Comment thread midi2/src/channel_voice2/note_on.rs Outdated
Comment thread midi2/src/channel_voice2/note_on.rs Outdated
Comment thread midi2/src/traits.rs Outdated
Comment thread midi2/src/traits.rs Outdated
@BenLeadbetter
Copy link
Copy Markdown
Collaborator

Clippy has some good suggestions btw 🤓

@Rahzael
Copy link
Copy Markdown
Author

Rahzael commented Jan 21, 2026

Clippy has some good suggestions btw 🤓

I'll check them out! I need to figure how to get it to automatically run with my setup so I see them myself before uploading. I had assumed that it would automatically run whenever I ran cargo test but apparently that isn't the case.

@BenLeadbetter
Copy link
Copy Markdown
Collaborator

I'll check them out! I need to figure how to get it to automatically run with my setup so I see them myself before uploading. I had assumed that it would automatically run whenever I ran cargo test but apparently that isn't the case.

You should be able to run them locally with

> cargo clippy --all-features

Comment thread midi2/src/conversion.rs Outdated
@@ -0,0 +1,672 @@
pub trait FromCv2<T>: Sized {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new traits should live in the traits module. This would be consistent with the other conversion traits and also ensure they end up in the crate prelude automatically.

Comment thread midi2/src/channel_voice2/note_on.rs Outdated
@BenLeadbetter
Copy link
Copy Markdown
Collaborator

How's the work here coming along ? Is there anything I can do to help ?

I'd like to get this feature into the forthcoming 0.12.0 feature release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants