fix(cargo-wdk): remove network dependency from automatic test signing - #725
Draft
Shravan Vasista (svasista-ms) wants to merge 1 commit into
Draft
fix(cargo-wdk): remove network dependency from automatic test signing#725Shravan Vasista (svasista-ms) wants to merge 1 commit into
Shravan Vasista (svasista-ms) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Shravan Vasista (svasista-ms)
August 25, 2026 12:19
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates cargo-wdk’s test-signing flow to avoid requiring network access (by removing signtool sign timestamping), and hardens automatic test-certificate selection by choosing a valid code-signing cert from WDRTestCertStore via SHA-1 thumbprint + remaining validity (creating a new cert when needed, and serializing store access with a named mutex).
Changes:
- Remove
/t http://timestamp.digicert.comfrom test signing and switchsigntoolto select the cert via/sha1 <thumbprint>. - Add store-certificate discovery/selection based on EKU + expiry margin, with parsing of
certmgr -v -soutput and unit tests for the parser. - Update cargo-wdk build tests to match the new cert lookup/export/signing behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/cargo-wdk/src/actions/build/tests.rs | Updates mocked command expectations to cover cert lookup sequences and /sha1-based signing. |
| crates/cargo-wdk/src/actions/build/package_task.rs | Implements thumbprint-based certificate selection/export, removes timestamping, and adds certmgr output parsing + tests. |
| crates/cargo-wdk/src/actions/build/error.rs | Adds a dedicated error for “created cert but still couldn’t find a usable one”. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+2658
to
+2660
| /// Mocks the `certmgr -v -s <store>` lookups. The outputs are returned in | ||
| /// order and then repeated, so a `[not found, not found, found]` sequence | ||
| /// covers one create-then-select cycle per driver. |
Comment on lines
+2661
to
+2668
| fn expect_certmgr_cert_lookup(mut self, outputs: Vec<Output>) -> Self { | ||
| let expected_certmgr_command: &'static str = "certmgr.exe"; | ||
| let expected_certmgr_args: Vec<String> = | ||
| vec!["-s".to_string(), "WDRTestCertStore".to_string()]; | ||
| let expected_certmgr_args: Vec<String> = vec![ | ||
| "-v".to_string(), | ||
| "-s".to_string(), | ||
| "WDRTestCertStore".to_string(), | ||
| ]; | ||
| let mut call_index = 0usize; |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
==========================================
+ Coverage 82.64% 82.83% +0.18%
==========================================
Files 25 25
Lines 6459 6628 +169
Branches 6459 6628 +169
==========================================
+ Hits 5338 5490 +152
+ Misses 989 988 -1
- Partials 132 150 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signtool signhard-coded/t http://timestamp.digicert.com, so packaging a driver failed on machines without internet access. Test signatures are trusted only while the signing certificate is valid, so timestamping them adds little value.In this PR, the timestamp switch is dropped during test signing and the certificate used in the automated test signing flow is selected by its SHA-1 thumbprint and validity rather than subject name alone. Certificates are now chosen from the
WDRTestCertStorelisting, reused only when they carry the code-signing EKU and have 90+ days of validity remaining. OtherwiseWDRLocalTestCertis created withmakecert. A named mutex serializes store access so concurrent builds do not race to create duplicate certificates.This also removes the early return on an existing
WDRLocalTestCert.cerin the target directory, which previously short-circuited the check and masked an expired or deleted store certificate.Fixes #631