Skip to content

Assert action bar wait result to avoid false positives #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EmmaYuan1015 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Assert action bar wait result to avoid false positives #2689

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ec304f
fix(smoke): assert action bar wait result to avoid false positives
EmmaYuan1015 May 28, 2026
c013cb8
Merge branch 'master' into smoke-actionbar-timeout-assertion
EmmaYuan1015 Jun 5, 2026
4639a49
Merge branch 'master' into smoke-actionbar-timeout-assertion
EmmaYuan1015 Jun 9, 2026
fee7642
test(smoke): optimize action bar wait assertion flow
EmmaYuan1015 Jun 9, 2026
0009dd8
Merge branch 'master' into smoke-actionbar-timeout-assertion
EmmaYuan1015 Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions test/smoke/suites/actionBar.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for details.

import { Page } from "playwright";
import { SmokeTestLogger } from "./helper/smokeTestLogger";
import { app, screenshots } from "./main";
import { ElementHelper } from "./helper/elementHelper";
Expand All @@ -12,9 +11,9 @@ import assert = require("assert");

export function startActionBarTests(): void {
describe("ActionBarTest", () => {
async function initApp(): Promise<Page> {
async function initApp(): Promise<void> {
await app.launch();
return app.getMainPage();
await app.getMainPage();
}

async function dispose(this: Mocha.Context): Promise<void> {
Expand Down Expand Up @@ -57,7 +56,6 @@ export function startActionBarTests(): void {
Element.debugActionItemButtonSelector,
);
await actionButton.click();

await ComponentHelper.waitPackagerStateIncludes(
"primitive-square",
TimeoutConstants.PACKAGER_STATE_TIMEOUT,
Expand Down
Loading