feat: the property, scope and starting-style at-rules - #60
Draft
Kristofer Baxter (kristofer-baxter) wants to merge 2 commits into
Draft
feat: the property, scope and starting-style at-rules#60Kristofer Baxter (kristofer-baxter) wants to merge 2 commits into
Kristofer Baxter (kristofer-baxter) wants to merge 2 commits into
Conversation
Adds scopes for `@container`: the container name, size features, logical operators, `style()` queries and `scroll-state()` queries, including grouped and boolean forms. The body carries `meta.at-rule.container.body.css` and both of its braces are scoped, matching the other block at-rules. A query in parentheses may itself be a parenthesised query, so the groups nest rather than close at the first bracket, and `<general-enclosed>` is parsed so a bracket inside a string is not read as one. A `<style-query>` is parsed recursively, so `not`, grouped queries and ranges are not read as a declaration list. A feature value is a component value, so a function may stand in for a keyword. `style()` holds a `<declaration-value>`, where a `;` nested in brackets or a balanced block is part of the value. Its declaration-value region therefore ends only at `}` or `)`, so `style(--x: [a;b])` keeps the whole value. The container name is a `<custom-ident>`, so it may begin with an escape. Only `none`, `and`, `not` and `or` are reserved, so `style` and `scroll-state` are names in their own right and only a bracket straight after either one makes it a query function. The query is optional, so a name may run into the body, and the prelude is a comma-separated list, so a name may start at a comma. The cost of a prelude is linear in its length: doubling a 12.5 KB prelude twice roughly doubles the time each step, and 50 KB takes under half a second, which is far past any real stylesheet. An unknown query function is `<general-enclosed>` wherever a query is valid, not only inside parentheses. A `)` separates the identifier that follows it, so `)and(` needs no whitespace. A style range may be written without spaces, value first, or chained, and its custom property name stops at the comparison. A size container feature takes a length or a ratio, and only `orientation` takes a keyword, so the values `@media` accepts are not query values here: `@container (width: fullscreen)` reads `fullscreen` as no more than an identifier. A malformed prelude leaks its header scope to the rest of the file, which is what `@media` already does. `@container` has no semicolon form, so `@container nonsense;` leaks with the rest of them.
Adds scopes for `@property` descriptors and its custom property name,
`@scope` preludes as selectors with the scope root and the scoping limit
distinguished, and the `@starting-style` body. Block at-rules whose
prelude is omitted entirely open their body correctly.
A `@scope` prelude holds a selector list, so its parentheses balance.
`@scope (:host(.a)) to (.b)` scopes as a selector rather than closing
the prelude at the inner bracket.
The scoping limit keyword is an identifier, so `t\6f` and `\t\o` are
both recognised as `to`. A hexadecimal escape is at most six digits, so
`\00000074o` is not. A custom property name ending in a hexadecimal
escape consumes the whitespace that terminates it, so the name is not
cut short.
`@scope` takes a declaration written straight into its body, without a
selector around it, and so does a `@starting-style` nested inside a
style rule, so a declaration in either position scopes as one. A
top-level `@starting-style` holds style rules, and the test uses the
nested form for that reason.
An unclosed bracket in a `@scope` prelude, as in `@scope (:host(.a){`,
carries the prelude scope further than `main` does. It leaks rather than
recovering, which is the direction this grammar wants, but it is a
difference and worth knowing about.
Kristofer Baxter (kristofer-baxter)
force-pushed
the
oss/property-scope
branch
from
September 2, 2026 01:00
026ead0 to
af19d50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 of 6, and a draft until #59 merges.
A pull request from a fork can only be based on
main, so the diff here includes every commit beneath this one in the stack. The commit this pull request adds isaf19d50, the last one on the branch. Once #59 merges the diff will reduce to that commit alone, and I will mark this ready.Part of the split of #57.
Adds scopes for
@propertydescriptors and its custom property name, for@scopepreludes as selectors with the scope root and the scoping limit distinguished, and for the@starting-stylebody. Block at-rules that omit the prelude entirely now open their body correctly.A
@scopeprelude holds a selector list, so its parentheses balance.@scope (:host(.a)) to (.b)scopes as a selector instead of closing the prelude at the inner bracket.The scoping limit keyword is an identifier, so
t\6fand\t\oare both recognised asto. A hexadecimal escape is at most six digits, so\00000074ois not. A custom property name ending in a hexadecimal escape consumes the whitespace that terminates it, so the name is not cut short.@scopetakes a declaration written straight into its body, without a selector around it, and so does a@starting-stylenested inside a style rule. A declaration in either position scopes as one. A top-level@starting-styleholds style rules, which is why the test uses the nested form.One difference from
mainworth flagging: an unclosed bracket in a@scopeprelude, as in@scope (:host(.a){, carries the prelude scope further thanmaindoes. It leaks instead of recovering.