Add "Create new Azure Container Registry" option to the Build Image in Azure registry pick#547
Draft
bwateratmsft with Copilot wants to merge 4 commits into
Draft
Add "Create new Azure Container Registry" option to the Build Image in Azure registry pick#547bwateratmsft with Copilot wants to merge 4 commits into
bwateratmsft with Copilot wants to merge 4 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix missing '+ Create new Azure Container Registry...' option
Add "Create new Azure Container Registry" option to the Build Image in Azure registry pick
Jul 22, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
There was a problem hiding this comment.
Ideally we would convert this whole thing into a wizard...and then just reuse CreatePickAcrPtomptStep
Contributor
Author
There was a problem hiding this comment.
Done in 3d237d2: scheduleRunRequest is now an AzureWizard flow, and ACR selection now reuses CreatePickAcrPromptStep (via a shared wizard context type) instead of calling a separate direct picker path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Select registry" step of Azure Container Registry: Build Image in Azure... offered only existing registries, with no way to create a new one — unlike the push-image flow. The step relied on a bare
registryExperiencecall rather thanCreatePickAcrPromptStep.Changes
pickAcrhelper (commands/registries/azure/pickAcr.ts): given a subscription node, lists its ACRs plus a+ Create new Azure Container Registry...item; on selection it runscreateAzureRegistryand returns the created node.scheduleRunRequest: swapped the directregistryExperienceregistry pick forsubscriptionExperience→pickAcr, so "Build Image in Azure..." now surfaces the create-new option.CreatePickAcrPromptStep(push-image flow): refactored to delegate topickAcr, removing duplicated pick/create logic and keeping both flows consistent.pickAcrreturnsUnifiedRegistryItem<AzureRegistry>, which is assignable toCommonRegistryfor the push flow and yields anAzureRegistryItemwrappedItemforscheduleRunRequest— no unsafe casts needed.This deliberately avoids converting
scheduleRunRequestinto a full wizard (noted in the issue as conflicting with #112).Notes for reviewers
Type-check/build could not be run in the sandbox —
pnpm installfailed with DNS errors (ENOTFOUND packagefeedproxy.microsoft.io), so TypeScript never installed. Please runpnpm build/pnpm lintto confirm.