Add wslc support#526
Draft
patverb wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds preview support for the Windows-only WSLC (WSL Container CLI) runtime across the extension, including runtime selection/registration, telemetry reporting, clearer non-Windows error handling, and enabling the .NET SDK container run task flow by publishing to a tar archive and loading it via wslc.
Changes:
- Register a new Windows-only
WslcClientruntime option (including settings UI + “choose runtime” command) and track it in telemetry. - Improve runtime selection behavior by failing fast with a clear error when WSLC is selected on non-Windows hosts.
- Update the .NET SDK container run task to publish to a temporary image tar and load it into WSLC before running (with best-effort cleanup).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/telemetry/registerRuntimeTelemetryHandler.ts | Adds telemetry classification for the WSLC client. |
| src/tasks/netSdk/netSdkTaskUtils.ts | Adds archive-output support for dotnet publish and a load command helper for WSLC. |
| src/tasks/netSdk/NetSdkRunTaskProvider.ts | Implements publish→load→run flow for WSLC with temp tar cleanup. |
| src/runtimes/RuntimeManager.ts | Adds explicit non-Windows rejection when WSLC is selected. |
| src/runtimes/clients/AutoConfigurableWslcClient.ts | Introduces an auto-configurable WSLC client pinned to wslc. |
| src/extension.ts | Registers the WSLC client on Windows and wires reconfigure behavior. |
| src/commands/chooseContainerRuntime.ts | Exposes WSLC as a runtime choice on Windows; makes orchestrator optional. |
| package.nls.json | Documents Windows-only availability for the containerClient setting. |
| package.json | Adds WSLC to the containerClient enum + bumps container-client dependency. |
| CHANGELOG.md | Notes WSLC support in the unreleased changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+6
to
10
| import { ClientIdentity, WslcClient } from '@microsoft/vscode-container-client'; | ||
| import * as vscode from 'vscode'; | ||
| import { configPrefix } from '../constants'; | ||
| import { isWindows } from '../utils/osUtils'; | ||
| import { TimeoutPromiseSource } from '../utils/promiseUtils'; |
bwateratmsft
marked this pull request as draft
July 16, 2026 20:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add wslc (WSL Container CLI) as a Windows-only container runtime (preview)
Description
Registers the new WslcClient from @microsoft/vscode-container-client as a selectable, Windows-only container runtime, exposed as "WSLC (Windows only, preview)". It's treated as an alternative to Docker/Podman, mirroring the existing auto-configurable client pattern.
Depends on microsoft/vscode-docker-extensibility# ( @microsoft/vscode-container-client@^0.6.0 ).
What's added / changed
• AutoConfigurableWslcClient — mirrors the Docker/Podman auto-configurable clients, but pins the command to wslc (ignores the shared containers.containerCommand override, since wslc is a specific named binary).
• extension.ts — registers the wslc client only on Windows ( isWindows() gate), and wires up reconfigure .
• RuntimeManager — if wslc is selected on a non-Windows host, rejects with a clear "WSLC is only available on Windows" error instead of a confusing timeout.
.NET SDK container task support
The .NET SDK's LocalRegistry publish target only supports Docker/Podman. To support wslc, the SDK run task now:
Docker/Podman continue to use LocalRegistry unchanged.
Fixes #501