[rtabmap] update to 0.23.7#52607
Open
matlabbe wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.What changed
rtabmap:arm64-windows=cascadeentry fromscripts/ci.feature.baseline.txt.Here is what Claude had to say why we updated rtabmap feature baseline for arm64-windows:
Why
When bumping rtabmap to 0.23.7, CI failed the feature-test check with:
The baseline marked rtabmap on arm64-windows as
cascade(i.e. expected to beskipped because a dependency isn't supported on that platform). That is no
longer true: rtabmap's entire core dependency chain builds on arm64-windows, so
rtabmap[core]and most feature combinations now build successfully — whichconflicts with the
cascadeexpectation and fails CI.The
cascadeentry predated arm64-windows dependency support maturing and wassimply never cleaned up. Because vcpkg only feature-tests ports that are edited
in a PR, the stale expectation was never re-checked until this version bump
triggered a fresh run and exposed it.
Scope of the change
rtabmap:arm64-windows=cascadeline.rtabmap[k4w2,openni2](arm | !windows)=cascade(kinectsdk1/kinectsdk2)rtabmap[opencv-cuda](!x64 | android | osx)=cascade(cuda)realsense2cascades automatically via its own platform restrictionrtabmap:arm64-linux=cascade— that one is still valid, becausertabmap's core deps
g2oandopencvstill cascade on arm64-linux.