[unarr] add new package#47734
Merged
Merged
Conversation
JavierMatosD
left a comment
JavierMatosD
left a comment
Contributor
There was a problem hiding this comment.
Is this library vending 7z?
BillyONeal
reviewed
Oct 14, 2025
| vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS | ||
| FEATURES | ||
| "enable-7z" ENABLE_7Z | ||
| "zlib-crc32" USE_ZLIB_CRC |
Member
There was a problem hiding this comment.
I don't think this should be a feature since you're unconditionally depending on zlib. Unless I'm missing something?
Contributor
Author
There was a problem hiding this comment.
OK, I will keep this option ON at any case.
Contributor
Author
|
Dunno maybe Windows OS has some issues with 7zip port? |
Contributor
|
Vcpkg tool bug, #47757 (comment). |
Contributor
Author
|
Thank you for your explanation, could you notify when storm would calm down and vcpkg would work? Thanks. |
Member
|
microsoft/vcpkg-tool#1817 bug fix |
BillyONeal
added
the
requires:tool-release
BillyONeal
removed
the
requires:tool-release
Member
|
It looks like the failures are now "real" |
Contributor
Author
What would be insight for this case? |
Member
If upstream doesn't care about supporting shared libraries, |
Member
|
Unfortunately there are more bits that seem to have hard coded dependencies on the vendored lzmasdk. Examples: https://github.com/selmf/unarr/blob/1df8ab3d281409e9fe6bed8bf485976bb47f5bef/CMakeLists.txt#L55-L67 https://github.com/selmf/unarr/blob/1df8ab3d281409e9fe6bed8bf485976bb47f5bef/zip/zip.h#L21 I'm not sure it's going to be easy to devendor this thing :( |
dg0yt
reviewed
Oct 18, 2025
| target_compile_definitions(unarr PRIVATE -DHAVE_BZIP2) | ||
| # Bzip2 upstream does not supply a .pc file. Add it to Libs.private. | ||
| - set(PROJECT_LIBS_PRIVATE "-I${BZIP2_INCLUDE_DIRS} -l${BZIP2_LIBRARIES}") | ||
| + set(PROJECT_LIBS_PRIVATE "${PROJECT_LIBS_PRIVATE} -I${BZIP2_INCLUDE_DIRS} -l${BZIP2_LIBRARIES}") |
Contributor
There was a problem hiding this comment.
Not your bug, but: -I doesn't belong to pkg-config's Libs.private.
…for external 7zip codecs
Co-authored-by: Kai Pastor <dg0yt@darc.de>
Co-authored-by: Kai Pastor <dg0yt@darc.de>
Co-authored-by: Kai Pastor <dg0yt@darc.de>
Contributor
Author
I think nor unarr nor 7zip intend to support Windows OS shared library build. |
Contributor
7zip is fine. The 7zip build in vcpkg uses CMake, but with pristine |
Contributor
Author
Well I will place supports for |
BillyONeal
reviewed
Oct 20, 2025
| "description": "A decompression library for rar, tar, zip and 7z archives.", | ||
| "homepage": "https://github.com/selmf/unarr", | ||
| "license": "LGPL-3.0-only", | ||
| "supports": "!(windows & !static)", |
Member
There was a problem hiding this comment.
Unfortunately:
!(windows & !static)!windows | !static(DeMorgan)
excludes every triplet we have so this doesn't pass the 'tested on at least one official triplet' requirement we need to put in the curated registry.
Did you intend !(windows & static)?
Contributor
There was a problem hiding this comment.
Isn't it simply "SUPPORTS: NOT (WINDOWS & DYNAMIC)"?
* `!(windows & !static)` * `!windows | !static` (DeMorgan)
!(windows & !static)!windows | !!static!windows | static
Contributor
Author
There was a problem hiding this comment.
I intended to skip shared library builds for Windows OS, but keep everything else.
Is it "supports": "!windows | static", by any chance?
Member
There was a problem hiding this comment.
Isn't it simply "SUPPORTS: NOT (WINDOWS & DYNAMIC)"?
I am an idiot, sorry :(
Contributor
Author
Is there difference between:
if(VCPKG_TARGET_IS_WINDOWS)
vcpkg_check_linkage(ONLY_STATIC_LIBRARY)
endif()? |
Member
Yes. |
BillyONeal
approved these changes
Oct 23, 2025
BillyONeal
left a comment
BillyONeal
left a comment
Member
There was a problem hiding this comment.
Thanks for the new port, for devendoring stuff, and sorry for the confusion. Thanks also @dg0yt for pointing out where Bill was a dum dum.
Contributor
The first is checked by vcpkg tool when making an installation plan. Regardless of per-port triplet customization. The second is checked by CMake when vcpkg gets to actually building the port. Subject to per-port triplet customization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.https://repology.org/project/unarr/versions