fix(apps): log inbound activities at info, warn on missing Authorization#425
Draft
corinagum wants to merge 3 commits into
Draft
fix(apps): log inbound activities at info, warn on missing Authorization#425corinagum wants to merge 3 commits into
corinagum wants to merge 3 commits into
Conversation
…zation header Inbound activities only logged at debug (and only after auth+parse), and the missing-Bearer-token path returned 401 with no log line. At default info level this made it impossible to tell "request never arrived" from "request arrived and was silently 401'd by the SDK." Adds an info-level entry log on every inbound and a warn log when rejecting for a missing or malformed Authorization header. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional diagnostics to the Apps HTTP ingress path (HttpServer.handle_request) to make it easier to determine whether inbound Teams activities are reaching the SDK and why they may be rejected.
Changes:
- Log an inbound activity summary (
type/id) at info level at the start of request handling. - Emit a warning when the
Authorizationheader is missing or doesn’t contain aBearertoken (before returning 401).
…ype/id Addresses Copilot review feedback on #425: - Activity type/id come from the untrusted request body before auth runs. Strip control characters and cap length before formatting them into log lines so an attacker cannot forge multi-line log entries. - Include type/id on the missing-Authorization-header warn, so users running at WARNING level can correlate the rejection with a specific activity without needing the preceding info entry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Per review feedback: the info-level entry log on every inbound activity is redundant with the existing debug log nearby, and operators who want diagnostic visibility into "did the request reach the SDK" can already get it by flipping the logger to debug. The genuinely new diagnostic value is the warn on the missing-or-malformed Authorization header path, which is silent at every log level today; that stays. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Draft
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
uv run poe check(ruff format + ruff check, all pass)uv run pyright src/microsoft_teams/apps/http/http_server.py(0 errors)uv run poe test(580/580 pass)