feat: Add Microsoft Agent Framework skills#191
feat: Add Microsoft Agent Framework skills#191shinhf wants to merge 4 commits intomicrosoft:mainfrom
Conversation
@microsoft-github-policy-service agree [company="Kamil Cisewski"] |
@microsoft-github-policy-service agree |
thegovind
left a comment
There was a problem hiding this comment.
Review summary
This is a substantive contribution: 11 new Microsoft Agent Framework (MAF) Python skills under a new azure-maf-python plugin, plus matching tests/scenarios and a maf-architect agent. The skills are well-organized and in scope. However, a few blockers should be resolved before merge.
Issues
🔴 Blocking
- Branch is dirty / out of date.
mergeStateStatus: DIRTY. The PR head is the contributor'smainand is now 26k additions ahead with conflicts. Please merge or rebase againstmicrosoft/skills:mainand resolve conflicts. - Empty PR description. A 91-file / 26k-line PR with no description makes review harder than it needs to be. Please add at least:
- The 11 skills introduced (and one-line purpose for each)
- The new plugin (
azure-maf-python) and how it slots in alongsideazure-sdk-python - The new agent (
maf-architect) - How this relates to the existing
agent-framework-azure-ai-pyskill inazure-sdk-python - Test pass-rate from
tests/scenarios/
- Overlap with existing
agent-framework-azure-ai-py. That skill already covers ChatAgent /run/run_stream/AgentThreadfor persistent Foundry agents. The newazure-maf-getting-started-pycovers the same primitives. Decide one of:- Mark the existing skill as superseded and remove it as part of this PR, OR
- Keep both and add a "See also" cross-reference in each so the agent doesn't load conflicting variants for the same intent.
🟡 Recommended
- README catalog. With 11 new skills, the language counts in
README.mdneed updating (Python count moves from 41 → 52, total from 130 → 141). The diff showsREADME.mdis touched but worth a final check. - Skill sizing. Several of the new skills look broad ("orchestration-patterns", "workflow-fundamentals", "declarative-workflows"). For agent context windows, prefer one focused intent per skill. If any of these exceed ~300 lines in
SKILL.mdbody, consider pushing detail intoreferences/*.mdand keeping the body lean — the loaded context cost matters. - YAML frontmatter consistency. Spot-checked
azure-maf-getting-started-py: it usesversion: 0.1.0while the existingagent-framework-azure-ai-pyusesmetadata.versionpluslicenseandmetadata.author. Pick one shape and apply across all 11 new skills so tooling can rely on it. agent-frameworkversion pinning. The skill teachespip install -U agent-frameworkand--premodes. Pinning to a known-good minor (agent-framework>=X,<Y) for the examples avoids breaking samples on the next pre-release.headRefNameismain. PRs filed from a fork'smainare common but make follow-up commits messy. Future iterations are easier from a feature branch.
🟢 Nits
- Consider whether
azure-maf-claude-agent-sdk-pybelongs in this catalog — Claude SDK is third-party. If MAF officially supports it as a chat client adapter that's fine; please make that connection explicit in the skill description.
Suggested follow-ups
- After this lands, file a follow-up to add matching
azure-maf-*-dotnetskills since MAF is .NET-first as well — the catalog story is incomplete with Python-only.
Thanks for the contribution. The structure is solid; mostly need a description, conflict resolution, and the overlap decision before merge.
No description provided.