Skip to content

feat: Add Microsoft Agent Framework skills#191

Open
shinhf wants to merge 4 commits intomicrosoft:mainfrom
shinhf:main
Open

feat: Add Microsoft Agent Framework skills#191
shinhf wants to merge 4 commits intomicrosoft:mainfrom
shinhf:main

Conversation

@shinhf
Copy link
Copy Markdown

@shinhf shinhf commented Mar 13, 2026

No description provided.

@shinhf
Copy link
Copy Markdown
Author

shinhf commented Mar 13, 2026

@shinhf please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="Kamil Cisewski"]

@shinhf
Copy link
Copy Markdown
Author

shinhf commented Mar 13, 2026

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@shinhf shinhf changed the title Add Microsoft Agent Framework skills feat: Add Microsoft Agent Framework skills Mar 20, 2026
Copy link
Copy Markdown
Collaborator

@thegovind thegovind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

This is a substantive contribution: 11 new Microsoft Agent Framework (MAF) Python skills under a new azure-maf-python plugin, plus matching tests/scenarios and a maf-architect agent. The skills are well-organized and in scope. However, a few blockers should be resolved before merge.

Issues

🔴 Blocking

  • Branch is dirty / out of date. mergeStateStatus: DIRTY. The PR head is the contributor's main and is now 26k additions ahead with conflicts. Please merge or rebase against microsoft/skills:main and resolve conflicts.
  • Empty PR description. A 91-file / 26k-line PR with no description makes review harder than it needs to be. Please add at least:
    • The 11 skills introduced (and one-line purpose for each)
    • The new plugin (azure-maf-python) and how it slots in alongside azure-sdk-python
    • The new agent (maf-architect)
    • How this relates to the existing agent-framework-azure-ai-py skill in azure-sdk-python
    • Test pass-rate from tests/scenarios/
  • Overlap with existing agent-framework-azure-ai-py. That skill already covers ChatAgent / run/run_stream / AgentThread for persistent Foundry agents. The new azure-maf-getting-started-py covers the same primitives. Decide one of:
    • Mark the existing skill as superseded and remove it as part of this PR, OR
    • Keep both and add a "See also" cross-reference in each so the agent doesn't load conflicting variants for the same intent.

🟡 Recommended

  • README catalog. With 11 new skills, the language counts in README.md need updating (Python count moves from 41 → 52, total from 130 → 141). The diff shows README.md is touched but worth a final check.
  • Skill sizing. Several of the new skills look broad ("orchestration-patterns", "workflow-fundamentals", "declarative-workflows"). For agent context windows, prefer one focused intent per skill. If any of these exceed ~300 lines in SKILL.md body, consider pushing detail into references/*.md and keeping the body lean — the loaded context cost matters.
  • YAML frontmatter consistency. Spot-checked azure-maf-getting-started-py: it uses version: 0.1.0 while the existing agent-framework-azure-ai-py uses metadata.version plus license and metadata.author. Pick one shape and apply across all 11 new skills so tooling can rely on it.
  • agent-framework version pinning. The skill teaches pip install -U agent-framework and --pre modes. Pinning to a known-good minor (agent-framework>=X,<Y) for the examples avoids breaking samples on the next pre-release.
  • headRefName is main. PRs filed from a fork's main are common but make follow-up commits messy. Future iterations are easier from a feature branch.

🟢 Nits

  • Consider whether azure-maf-claude-agent-sdk-py belongs in this catalog — Claude SDK is third-party. If MAF officially supports it as a chat client adapter that's fine; please make that connection explicit in the skill description.

Suggested follow-ups

  • After this lands, file a follow-up to add matching azure-maf-*-dotnet skills since MAF is .NET-first as well — the catalog story is incomplete with Python-only.

Thanks for the contribution. The structure is solid; mostly need a description, conflict resolution, and the overlap decision before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants