RIFLA: Support emission of loops over constant arrays#3101
Merged
Conversation
This updates the `Adaptive_RIFLA` profile to support emission of loops over arrays with constant, compile-time known content. Where the prior looping support only handled loops with iteration-invariant internals, this updates RCA, Partial Eval, RIR, and QIR codegen to allow for arrays with constant content stored in the global section to be the source of iteration values within a loop. For now, only loops with variable types we already support work with this pattern, specifically loops over constant arrays of `Bool`, `Int`, and `Double`. Arrays of arrays are not supported, due to the lack of QIR compatible mechanism for dynamically querying the length of an array and Q# support for jagged arrays of arrays (ie: `[[1.0], [2.0, 3.0]]`). Follow up PRs will add support for iteration over constant arrays of new types like `Qubit` and `Pauli`. Arrays with dynamic contents will be handled later down the line.
|
Change in memory usage detected by benchmark. Memory Report for 76291c3
|
billti
reviewed
Apr 7, 2026
orpuente-MS
reviewed
Apr 8, 2026
orpuente-MS
reviewed
Apr 9, 2026
orpuente-MS
reviewed
Apr 9, 2026
orpuente-MS
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
Adaptive_RIFLAprofile to support emission of loops over arrays with constant, compile-time known content. Where the prior looping support only handled loops with iteration-invariant internals, this updates RCA, Partial Eval, RIR, and QIR codegen to allow for arrays with constant content stored in the global section to be the source of iteration values within a loop.For now, only loops with variable types we already support work with this pattern, specifically loops over constant arrays of
Bool,Int, andDouble. Arrays of arrays are not supported, due to the lack of QIR compatible mechanism for dynamically querying the length of an array and Q# support for jagged arrays of arrays (ie:[[1.0], [2.0, 3.0]]). Follow up PRs will add support for iteration over constant arrays of new types likeQubitandPauli. Arrays with dynamic contents will be handled later down the line.