Issue 24 and 16 fixed - #46
Conversation
Amanda Bertsch (abertsch72)
left a comment
There was a problem hiding this comment.
Confirmed 24 is fixed, thank you!
Your code for 16 works, but I don't think it's necessarily the best behavior. The original intent for 16 was to be able to select a editor for opening in the command line -- for instance, preferring nano or emacs over vim. I could see setting html or jupyter as a default being useful if that's your usual mode of operation, but since the no-args open is the command line open now, you lose the ability to open a notebook in the command line if every open rewrites that default. Maybe we should set the default command line view every time it's specified (e.g. "prax o 1 nano" rewrites the default for "prax o 1") but not change the default if we're opening in jupyter or html or ads? Or otherwise, we could keep this default-setting behavior but add arguments for command-line view. Which do you think would fit your use better?

- a special key in the database (user_id.db) holds the custom editor of the user
- every time a user specifies an editor when opens a notebook, the custom editor is updated so that in the next time the user can run notebooks without specifying it.
- when uninstalling/installing the new version, it is crucial to delete the SQLite databases (located in Appdata ->Roaming -> praxxis), otherwise, the database user_id.db won't have the new (key, values).