Skip to content

feat: remove localhost redirect url#436

Merged
leblocks merged 1 commit into
masterfrom
removing_usage_of_localhost_as_redirect_uri
May 24, 2026
Merged

feat: remove localhost redirect url#436
leblocks merged 1 commit into
masterfrom
removing_usage_of_localhost_as_redirect_uri

Conversation

@leblocks
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Health
Microsoft.PowerBI.Commands.Admin 83% 60%
Microsoft.PowerBI.Commands.Capacities 97% 55%
Microsoft.PowerBI.Commands.Common 39% 26%
Microsoft.PowerBI.Commands.Common.Test 45% 65%
Microsoft.PowerBI.Commands.Data 65% 57%
Microsoft.PowerBI.Commands.Profile 23% 20%
Microsoft.PowerBI.Commands.Profile.Test 7% 0%
Microsoft.PowerBI.Commands.Reports 30% 14%
Microsoft.PowerBI.Commands.Workspaces 94% 91%
Microsoft.PowerBI.Commands.Workspaces.Test 0% 0%
Microsoft.PowerBI.Common.Abstractions 54% 38%
Microsoft.PowerBI.Common.Api 4% 3%
Microsoft.PowerBI.Common.Authentication 2% 0%
Microsoft.PowerBI.Common.Client 31% 17%
Summary 25% (1897 / 7451) 24% (449 / 1850)

Minimum allowed line rate is 25%

@leblocks leblocks requested a review from Copilot May 19, 2026 16:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Removes the hard-coded http://localhost redirect URI from the Windows authentication factory, likely to avoid relying on a localhost loopback redirect in certain environments.

Changes:

  • Removed a non-.NET Framework-only fallback redirect URI (http://localhost) during MSAL public client app construction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Common/Common.Authentication/WindowsAuthenticationFactory.cs
@leblocks leblocks merged commit a06c21c into master May 24, 2026
9 checks passed
@leblocks leblocks deleted the removing_usage_of_localhost_as_redirect_uri branch May 24, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants