Add support for showing stacks from selected events#2418
Open
paulusakademius wants to merge 1 commit intomicrosoft:mainfrom
Open
Add support for showing stacks from selected events#2418paulusakademius wants to merge 1 commit intomicrosoft:mainfrom
paulusakademius wants to merge 1 commit intomicrosoft:mainfrom
Conversation
- Before this commit you could only show stacks for either a single time or a time range - This commit makes selecting any amount of events (no matterer what column of the event) and opening its stack (if there is one) possible - The stacks shown are now not only filtered by the time but also event id so no other events that happened at the same time are shown. - The behavior for selecting a time range remains the same as before
Contributor
Author
|
I thought this might be the most intuitive solution because it gives you the stacks for the events you selected. I kept the functionality for selecting a time range as it is, but when I noticed it only filters by time and it is possible for other events to happen at the same time, I thought maybe you could filter there for the event id too, like I did in the feature I implemented. What do you think about this, I think it might be more intuitive for the selection in the EventViewer. I am looking forward to hear your opinion on the idea and the code I already wrote. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to show stacks for selected events with the 'Open Any Stacks' function, regardless of the column of the event selected. Previously, stacks were only accessible for either a single time or a time range and defaulted to the everything when some other selection happened. With this update:
Issue #2394