Skip to content

Binary symbol-server lookup 404s for /Brepro builds with leading-zero #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivberg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Binary symbol-server lookup 404s for /Brepro builds with leading-zero #2417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/TraceEvent/Symbols/SymbolReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,16 @@ public string FindExecutableFilePath(string fileName, int buildTimestamp, int si
{
if (exeIndexPath == null)
{
exeIndexPath = fileName + @"\" + buildTimestamp.ToString("x") + sizeOfImage.ToString("x") + @"\" + fileName;
// Symbol-server convention (matched by symsrv.dll/symchk) is
// <TimeDateStamp:X8><SizeOfImage:X> — TimeDateStamp zero-padded
// to 8 hex digits, SizeOfImage variable-width with no padding.
// Using "x" without width drops the leading hex zero when the
// value is < 0x10000000, producing a malformed key that 404s
// even when the binary is indexed on the server. This hits real
// binaries built with /Brepro (deterministic builds), where the
// PE TimeDateStamp is a hash that can have leading zeros (e.g.
// SystemSettings.dll on recent Windows: TS=0x0D9F641E).
exeIndexPath = fileName + @"\" + buildTimestamp.ToString("x8") + sizeOfImage.ToString("x") + @"\" + fileName;
}

string cache = element.Cache;
Expand Down