openvmm: Add consomme, virtio-console and serial connect to ttrpc interface#3454
Open
damanm24 wants to merge 9 commits into
Open
openvmm: Add consomme, virtio-console and serial connect to ttrpc interface#3454damanm24 wants to merge 9 commits into
damanm24 wants to merge 9 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Extends the OpenVMM ttrpc VM service API to support virtio-console, a Consommé NIC backend, and “connect-as-client” semantics for serial/console backends.
Changes:
- Add
VirtioConsoleConfigand aconnectflag for serial/virtio-console endpoints in the VM service proto. - Add virtio-console device creation in the ttrpc entry, backed by UDS/named pipe (bind or connect).
- Add Consommé as a NIC backend option and map it into
net_backend_resources.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| openvmm/openvmm_ttrpc_vmservice/src/vmservice.proto | Adds proto messages/fields for virtio-console, Consommé backend, and connect semantics. |
| openvmm/openvmm_entry/src/ttrpc/mod.rs | Implements connect/bind selection for serial + new virtio-console plumbing and Consommé NIC parsing. |
| openvmm/openvmm_entry/src/serial_io.rs | Adds connect_serial to connect to pre-existing pipe/socket endpoints. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the ttrpc VM service interface with three new capabilities:
These new capabilities are utilized by a new workstream/proof-of-concept work to use OpenVMM as the VMM backend for WSLC.