Skip to content

openvmm: Add consomme, virtio-console and serial connect to ttrpc interface#3454

Open
damanm24 wants to merge 9 commits into
microsoft:mainfrom
damanm24:ttrpc-update
Open

openvmm: Add consomme, virtio-console and serial connect to ttrpc interface#3454
damanm24 wants to merge 9 commits into
microsoft:mainfrom
damanm24:ttrpc-update

Conversation

@damanm24
Copy link
Copy Markdown
Contributor

This PR extends the ttrpc VM service interface with three new capabilities:

  1. Virtio console device backed by UDS or named pipe
  2. Consommé NIC backend
  3. Adds a connect option for serial and virtio console devices so that openvmm can connect to a pre-existing socket/pipe as a client

These new capabilities are utilized by a new workstream/proof-of-concept work to use OpenVMM as the VMM backend for WSLC.

Copilot AI review requested due to automatic review settings May 11, 2026 17:42
@damanm24 damanm24 requested a review from a team as a code owner May 11, 2026 17:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Extends the OpenVMM ttrpc VM service API to support virtio-console, a Consommé NIC backend, and “connect-as-client” semantics for serial/console backends.

Changes:

  • Add VirtioConsoleConfig and a connect flag for serial/virtio-console endpoints in the VM service proto.
  • Add virtio-console device creation in the ttrpc entry, backed by UDS/named pipe (bind or connect).
  • Add Consommé as a NIC backend option and map it into net_backend_resources.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
openvmm/openvmm_ttrpc_vmservice/src/vmservice.proto Adds proto messages/fields for virtio-console, Consommé backend, and connect semantics.
openvmm/openvmm_entry/src/ttrpc/mod.rs Implements connect/bind selection for serial + new virtio-console plumbing and Consommé NIC parsing.
openvmm/openvmm_entry/src/serial_io.rs Adds connect_serial to connect to pre-existing pipe/socket endpoints.

Comment thread openvmm/openvmm_entry/src/ttrpc/mod.rs Outdated
Comment thread openvmm/openvmm_entry/src/ttrpc/mod.rs Outdated
Comment thread openvmm/openvmm_entry/src/serial_io.rs
Comment thread openvmm/openvmm_entry/src/ttrpc/mod.rs Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 11, 2026 17:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Comment thread openvmm/openvmm_entry/src/serial_io.rs
Comment thread openvmm/openvmm_entry/src/ttrpc/mod.rs Outdated
Comment thread openvmm/openvmm_entry/src/ttrpc/mod.rs Outdated
Comment thread openvmm/openvmm_entry/src/ttrpc/mod.rs Outdated
Copilot AI review requested due to automatic review settings May 11, 2026 19:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings May 11, 2026 22:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Comment thread openvmm/openvmm_entry/src/serial_io.rs
Comment thread openvmm/openvmm_entry/src/ttrpc/mod.rs
Comment thread vmm_tests/vmm_tests/tests/tests/ttrpc.rs Outdated
Comment thread vmm_tests/vmm_tests/tests/tests/ttrpc.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants