Fix/sync listener bug and test improvements

[Lokesh Muthuraj (lokeshmuthuraj)]

Summary

This PR fixes a bug in the receiver sync socket code and improves test compatibility with modern pytest versions.

Changes

Bug Fixes

1. Fixed incorrect variable check in receiver sync socket (endpointsync.c)

   • Issue: Line 309 was checking sync_listener == -1 but the variable sync_listener was initialized to 0 and never updated in the code.
   • Fix: Changed to check ss->listener == -1 (the actual listener socket)
   • Impact: This bug would cause the error check to always evaluate incorrectly, potentially causing the receiver to proceed with an invalid socket when the listen operation fails

2. Changed epoll_wait timeout from infinite to 1 second (endpointsync.c)

   • Changed from -1 (infinite wait) to 1000 milliseconds
   • Reason: Allows the event loop to periodically check the exit condition when receiver_exit_after_done is enabled
   • Impact: If the ntttcp client's exit message is dropped or not received by server sync thread due to timing issues, it could be left hanging indefinitely without checking for exit criteria.
   • Issue fixed: Intermittent Issue: NTTTCP on server side does not exit after test completes #103

Test Improvements

3. Updated pytest method names for compatibility (test/functional_test.py)

   • Changed setup() → setup_method(self, method)
   • Changed teardown() → teardown_method(self, method)
   • Ensures compatibility with modern pytest versions

4. Fixed typos and improved test reliability

   • Fixed typo: cooldowm → cooldown in test name
   • Fixed typo: defualt_threads → default_threads
   • Reduced test ports from 200 to 50 in test_mapping_option testcase since the test was getting hung. I faced the same issue and noticed there was already an issue for it: Ntttcp stalling with -P 200 #99
   • Removed duplicate -D flag in receiver command

Testing

• Functional tests pass with pytest (no warnings)
• Sender/receiver synchronization works correctly

Checklist

• Code builds successfully
• Tests pass
• No new compiler warnings
• Tested with different command parameters.

Before fix - got warnings for functional_test.py.

After fix - tests pass cleanly

[Lokesh Muthuraj (lokeshmuthuraj)]

@microsoft-github-policy-service agree company="Microsoft"

[Lokesh Muthuraj (lokeshmuthuraj)]

Simon Xiao (@simonxiaoss) Can you please review this PR? I'm unable to add reviewers to the PR.

[Lokesh Muthuraj (lokeshmuthuraj)]

Pratik Bedre (@pratikb2805) Can you review this PR?

[Lokesh Muthuraj (lokeshmuthuraj)]

lubaihua33 Can you please review this PR?

[Copilot]

Pull request overview

Fixes receiver-side sync socket handling to avoid hanging after tests complete, and updates functional tests for newer pytest compatibility.

Changes:

• Fix incorrect listener fd error check in receiver sync socket setup.
• Change sync thread epoll_wait() to a periodic timeout to allow exit-condition polling.
• Update pytest lifecycle hooks and fix minor test issues (typos, port count, duplicate flags).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/endpointsync.c	Corrects sync listener error check and adjusts epoll wait behavior for receiver exit handling.
test/functional_test.py	Updates pytest setup/teardown hook names and improves a few functional test cases for reliability/compatibility.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[lubaihua33]

lubaihua33 Can you please review this PR?

Yes, I have requested copilot to review.

[lubaihua33]

Lokesh Muthuraj (@lokeshmuthuraj) could you have a check the comments that copilot provided?

[Lokesh Muthuraj (lokeshmuthuraj)]

Lokesh Muthuraj (@lokeshmuthuraj) could you have a check the comments that copilot provided?

lubaihua33 Thanks. I have fixed the comments provided by Copilot.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[lubaihua33]

Lokesh Muthuraj (@lokeshmuthuraj) Could you please have a check for the new review comments provided by copilot?

[Lokesh Muthuraj (lokeshmuthuraj)]

Sure, I will check the new review comments and get back. Thanks.

[Lokesh Muthuraj (lokeshmuthuraj)]

lubaihua33 I have created 2 new issues #107 and #108 for the comments provided by copilot. I will take them in a different PR.

Please check and review this PR. I have resolved outstanding comments. Thanks.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.