DfciPkg: Demote expected not-found/anonymous-token logs to VERBOSE - #385
Open
jibz5 wants to merge 1 commit into
Open
DfciPkg: Demote expected not-found/anonymous-token logs to VERBOSE#385jibz5 wants to merge 1 commit into
jibz5 wants to merge 1 commit into
Conversation
The FrontPage/BootMenu queries settings and permissions using the local/anonymous auth token (0x0) and platform-optional setting IDs. DFCI correctly returns EFI_NOT_FOUND for these, but the paths logged at DEBUG_ERROR, flooding the error log with non-errors. Demote the expected EFI_NOT_FOUND / anonymous-token paths in GetIdentityProperties, HasWritePermissions, and InternalSystemSettingAccessGet/Set from DEBUG_ERROR to DEBUG_VERBOSE. Genuine failures (provisioning ACCESS_DENIED, 'Auth Protocol too early', 'Unexpected recursion') remain at DEBUG_ERROR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: da554102-ea7d-4e9b-b154-f481e6b4fa82
mu-automation
Bot
added
the
impact:non-functional
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FrontPage/BootMenu queries settings and permissions using the local/anonymous auth token (0x0) and platform-optional setting IDs. DFCI correctly returns EFI_NOT_FOUND for these, but the paths logged at DEBUG_ERROR, flooding the error log with non-errors.
Demote the expected EFI_NOT_FOUND / anonymous-token paths in GetIdentityProperties, HasWritePermissions, and
InternalSystemSettingAccessGet/Set from DEBUG_ERROR to DEBUG_VERBOSE. Genuine failures (provisioning ACCESS_DENIED, 'Auth Protocol too early', 'Unexpected recursion') remain at DEBUG_ERROR.
Description
<Include a description of the change and why this change was made.>
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
<Describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>