Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202511 #1751 +/- ##
=================================================
Coverage ? 0.71%
=================================================
Files ? 1004
Lines ? 345997
Branches ? 2669
=================================================
Hits ? 2465
Misses ? 343365
Partials ? 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Would it be possible, at end of dxe/ready to bot, to have mm produce a debug list of unblocked regions? This would allow auditing of what is unblocked, and maybe enable tracking back any other regions that might need reblocked? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current method of migrating MM accessible buffers is leaving the previously unblocked buffers unblocked, which will pose the risk of failing DRTM validation.
This change adds a new interface to support reblock pages to mitigate the issue.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
This was tested using QEMU Q35 and booted to UEFI shell.
Integration Instructions
Call
MmReblockMemoryRequestafter the old buffer is being replaced.