Bail PhysicalPresenceCallback if the mTcgNvs is not ready#1718
Draft
kuqin12 wants to merge 2 commits intomicrosoft:release/202511from
Draft
Bail PhysicalPresenceCallback if the mTcgNvs is not ready#1718kuqin12 wants to merge 2 commits intomicrosoft:release/202511from
PhysicalPresenceCallback if the mTcgNvs is not ready#1718kuqin12 wants to merge 2 commits intomicrosoft:release/202511from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202511 #1718 +/- ##
================================================
Coverage ? 1.61%
================================================
Files ? 159
Lines ? 37189
Branches ? 172
================================================
Hits ? 601
Misses ? 36588
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current
PhysicalPresenceCallbackwill directly access themTcgNvseven if the other handler was not invoked.This would cause the system to page fault due to the null pointer protection.
This change would bail the handler if the handler is invoked out of order.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
This is being tested.
Integration Instructions
N/A