Skip to content

add stdatomic.h for gcc-4.8.5#611

Open
deanxyuan wants to merge 1 commit intomicrosoft:mainfrom
deanxyuan:master
Open

add stdatomic.h for gcc-4.8.5#611
deanxyuan wants to merge 1 commit intomicrosoft:mainfrom
deanxyuan:master

Conversation

@deanxyuan
Copy link
Copy Markdown

  1. GCC-4.8.5 does not contain the file stdatomic.h, add a similar file (gcc-4.8.5-atomic.h) for compiling in gcc4.8.5
  2. Add option MI_ATOMIC_FOR_GCC485 in cmakelists.txt for this case

@ghost
Copy link
Copy Markdown

ghost commented Aug 10, 2022

CLA assistant check
All CLA requirements met.

@daanx
Copy link
Copy Markdown
Collaborator

daanx commented Oct 31, 2022

ah, I feel this adds a lot of complexity (new file, new options etc) for quite a narrow use case. Maybe it is enough to rename the gcc-4.8.5-atomic.h file to stdatomic.h and ensure it is in the include path? That may be enough to make it compile mimalloc as is?

@aengusjiang
Copy link
Copy Markdown

when merge this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants