This repository was archived by the owner on Jul 9, 2024. It is now read-only.
JsonParseNode.GetCollectionOf* methods now return null when called on non array types#163
Closed
Irame wants to merge 1 commit into
Closed
JsonParseNode.GetCollectionOf* methods now return null when called on non array types#163Irame wants to merge 1 commit into
Irame wants to merge 1 commit into
Conversation
baywet
reviewed
Jan 11, 2024
Contributor
|
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged. |
Contributor
|
Thanks for the contribution here @Irame If this is still relevant, please re-open the PR at the repo belows where the sources have been migrated to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Methods
GetCollectionOfPrimitiveValues,GetCollectionOfEnumValuesandGetCollectionOfObjectValuesinJsonParseNodenow return null when called on a non array type.For this to work the changes from microsoft/kiota-dotnet#174 are neccessary.
This change is part of the solution for the problem discussed here microsoft/kiota#3976.