chore(yarn): ensure network isolation for the build and tests#676
Merged
Conversation
Configure yarn install steps to use the internal npm mirror (https://domoreexp.pkgs.visualstudio.com/_packaging/npm-mirror/npm/registry/) instead of the public npm registry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace inline .npmrc generation with checked-in config files for npm mirror and ADO feed, and wire pipeline steps to use them via NPM_CONFIG_USERCONFIG. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
npmAuthenticate@0 requires authenticating a valid .npmrc path. Move checked-in configs to .npmrc filenames under dedicated folders and update workingFile and NPM_CONFIG_USERCONFIG references. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…github.com/microsoft/graphitation into pavelglac/ado-pipeline-npm-mirror-registry
pavelglac
force-pushed
the
pavelglac/ado-pipeline-npm-mirror-registry
branch
from
fd18179 to
b962048
Compare
pavelglac
changed the title
pavelglac
changed the title
📊 Benchmark Analysis Report✅ No significant performance changes detected Threshold: 5% change Updated: 2026-06-22T15:08:34.078Z |
user1736
reviewed
Jun 29, 2026
| git config user.email "gql-svc@microsoft.com" | ||
| git config user.name "Graphitation Service Account" | ||
| git fetch --depth=2 | ||
| git fetch origin main |
Contributor
There was a problem hiding this comment.
you sure you don't want to keep depth for faster checkout? fetching all history looks like overkill here
Contributor
Author
There was a problem hiding this comment.
Without it I was getting: fatal: shallow file has changed since we read it. For performance I would not be bothered.
user1736
reviewed
Jun 30, 2026
|
|
||
| parameters: | ||
| # settings: | ||
| # networkIsolationPolicy: Permissive,CFSClean |
Contributor
Author
There was a problem hiding this comment.
Yes, currently our pipeline cannot run in network isolation because of npmjs and github enpoints during the release.
celiac747
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Upgrade to yarn4 and ensure network isolation for the install, build and tests. For now there is not network isolation for the npm release (for the internal release there is). This will be addressed by bumping beachball and change the release pipeline according to microsoft/beachball#1281