Skip to content

Revert "[release-branch.go1.26] Ship .asc signature alongside .sig"#2414

Merged
dagood merged 1 commit into
microsoft/release-branch.go1.26from
revert-2403-dev/gadams/sig1.26
Jul 9, 2026
Merged

Revert "[release-branch.go1.26] Ship .asc signature alongside .sig"#2414
dagood merged 1 commit into
microsoft/release-branch.go1.26from
revert-2403-dev/gadams/sig1.26

Conversation

@dagood

@dagood dagood commented Jul 9, 2026

Copy link
Copy Markdown
Member

Copilot AI review requested due to automatic review settings July 9, 2026 20:33
@dagood dagood requested a review from a team as a code owner July 9, 2026 20:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts #2403 on the release branch, removing the behavior of emitting an additional .asc signature artifact alongside the existing .sig signature for signed archives.

Changes:

  • Stop copying the generated .sig signature file to a .asc file in the destination output.
  • Update the in-code comment describing how the .sig signing workflow operates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread eng/_util/cmd/sign/archive.go
@dagood dagood enabled auto-merge (squash) July 9, 2026 20:44
@dagood dagood merged commit f0de9aa into microsoft/release-branch.go1.26 Jul 9, 2026
43 checks passed
@dagood dagood deleted the revert-2403-dev/gadams/sig1.26 branch July 9, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants