Skip to content

Include default value for _info, use template#648

Merged
gdams merged 1 commit into
microsoft/mainfrom
dev/dagood/infodefault
Jul 9, 2026
Merged

Include default value for _info, use template#648
gdams merged 1 commit into
microsoft/mainfrom
dev/dagood/infodefault

Conversation

@dagood

@dagood dagood commented Jul 8, 2026

Copy link
Copy Markdown
Member

For _info, default isn't necessary for human-initiated runs (the sole option is automatically selected), but it seems that lacking a default breaks automatic triggers (scheduled and via AzDO API). Add a default to try to fix this.

This AzDO behavior is not documented. microsoft/go-infra#518 updates the doc that keeps track of quirks like this, if this ends up being a working solution.

Also, creates and uses a new pipelineymlgen template to avoid excessive duplication. It's also a central place to document the strategy involved.

@dagood dagood requested a review from a team as a code owner July 8, 2026 20:50
Copilot AI review requested due to automatic review settings July 8, 2026 20:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the _info “placeholder” parameter used in Azure DevOps pipelines to include a default value (to avoid breaking non-interactive triggers), and reduces duplication by factoring the _info parameter definition into a reusable pipelineymlgen inline template.

Changes:

  • Add a reusable eng/pipeline/util/info.gen.yml template for the _info parameter (including default).
  • Update pipeline .gen.yml sources to reference the new inline template instead of duplicating _info blocks.
  • Regenerate affected pipeline YAML outputs to include the _info.default field.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
eng/pipeline/util/info.gen.yml New reusable inline template for _info parameter (adds default).
eng/pipeline/rolling-internal-validation.gen.yml Switch _info parameter definition to the new inline template.
eng/pipeline/rolling-internal-validation-pipeline.yml Regenerated output: adds _info.default.
eng/pipeline/rolling-internal-validation-pipeline-unofficial.yml Regenerated output: adds _info.default.
eng/pipeline/go-docker-rolling-internal.gen.yml Switch _info parameter definition to the new inline template.
eng/pipeline/go-docker-rolling-internal-pipeline.yml Regenerated output: adds _info.default.
eng/pipeline/go-docker-rolling-internal-pipeline-unofficial.yml Regenerated output: adds _info.default.
eng/pipeline/cleanup-acr-images.gen.yml Switch _info parameter definition to the new inline template.
eng/pipeline/cleanup-acr-images-pipeline.yml Regenerated output: adds _info.default.
eng/pipeline/cleanup-acr-images-pipeline-unofficial.yml Regenerated output: adds _info.default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread eng/pipeline/util/info.gen.yml
@gdams gdams merged commit 2143b14 into microsoft/main Jul 9, 2026
30 checks passed
@gdams gdams deleted the dev/dagood/infodefault branch July 9, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants