Move oxlint config into scripts and remove the @fluentui-react-native/lint-config-rules package#4102
Open
JasonVMo wants to merge 2 commits intouser/jasonvmo/configs-part-1from
Open
Move oxlint config into scripts and remove the @fluentui-react-native/lint-config-rules package#4102JasonVMo wants to merge 2 commits intouser/jasonvmo/configs-part-1from
JasonVMo wants to merge 2 commits intouser/jasonvmo/configs-part-1from
Conversation
Saadnajmi
reviewed
May 7, 2026
| private projRoot: ProjectRoot = getProjectRoot(process.cwd()); | ||
| private result = 0; | ||
| private removedDevDeps: string[] = []; | ||
| private removedDevDeps: string[] = ['@fluentui-react-native/lint-config-rules']; |
Saadnajmi
reviewed
May 7, 2026
Comment on lines
-23
to
+24
| "build": "fluentui-scripts build", | ||
| "build-cjs": "tsgo --outDir lib-commonjs", | ||
| "build-core": "tsgo --outDir lib --module esnext --moduleResolution bundler", | ||
| "build": "tsgo", | ||
| "build-core": "tsgo", |
Collaborator
There was a problem hiding this comment.
Did this leak from the other TS change?
Saadnajmi
reviewed
May 7, 2026
Comment on lines
-23
to
+24
| "build": "fluentui-scripts build", | ||
| "build-cjs": "tsgo --outDir lib-commonjs", | ||
| "build-core": "tsgo --outDir lib --module esnext --moduleResolution bundler", | ||
| "build": "tsgo", | ||
| "build-core": "tsgo", |
Saadnajmi
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Move the oxlint configuration into the scripts package, exposed via an exports entry. Remove the previous configuration package. This is part of consolidating the configs and getting rid of having so many discrete packages here.