Open
Conversation
feordin
added
Bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+747
to
+749
| SearchOptions options = CreateSearchOptions( | ||
| resourceType: "Patient", | ||
| queryParameters: queryParameters); |
Comment on lines
+774
to
+776
| SearchOptions options = CreateSearchOptions( | ||
| resourceType: "Patient", | ||
| queryParameters: queryParameters); |
Comment on lines
+444
to
+452
| { "gender:missing", "true" }, | ||
| })), | ||
| }; | ||
| request.Headers.Add(KnownHeaders.Prefer, "respond-async"); | ||
|
|
||
| using HttpResponseMessage response = await _httpClient.SendAsync(request); | ||
| var content = await response.Content.ReadAsStringAsync(); | ||
| Assert.Equal(HttpStatusCode.Accepted, response.StatusCode); | ||
|
|
| Assert.NotNull(operationOutcome); | ||
|
|
||
| // Verify it contains an informational issue about _type being ignored | ||
| var issue = Assert.Single(operationOutcome.Issue, i => |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a URL already specifies the Fhir resource, the _type parameter is redundant and causes issues with our SQL query generator. This PR strips the redundant filter.
Related issues
Addresses [issue AB#188372].
Testing
Additional unit tests and E2E tests were created
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)