-
Notifications
You must be signed in to change notification settings - Fork 44
docs(testing): align validation guide with current frameworks #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
omribz156
wants to merge
4
commits into
microsoft:main
Choose a base branch
from
omribz156:docs/update-testing-validation-frameworks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3dd3bf9
docs(testing): align validation guide with current frameworks
omribz156 09c844e
docs: address testing guide review feedback
omribz156 8eb7c25
docs: preserve blueprint Terratest guidance
omribz156 4bd0921
Merge branch 'main' into docs/update-testing-validation-frameworks
katriendg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The directory tree uses
src/000-cloud/010-security-identity/as the example component, but the test files shown do not exist there. The actual010-security-identity/terraform/tests/directory containsiot-ops-cloud-reqs.tftest.hcl, notnaming-convention.tftest.hcloroutput-validation.tftest.hcl. Both of those files live insrc/000-cloud/000-resource-group/terraform/tests/, which is also the component the.tftest.hclcode example and thenpm run tf-testinvocations below target.Suggest changing the component path in the directory tree from
010-security-identityto000-resource-groupso the structure, file names, code example, and CLI commands all refer to the same component.