Fix .NET Framework 4.8 test hang in channel cancellation deadlock test - #156
Merged
Merged
Conversation
…tEventSlim, which signals the waiter directly instead of routing through the thread pool.
leti367
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deadlock regression test (
OpenChannelCancelDuringConfirmationDoesNotDeadlock) hangs on .NET Framework 4.8 becauseTaskCompletionSource.TrySetResult()withRunContinuationsAsynchronouslyroutes theTask.Wait()wake-up signal through the thread pool. When pool threads are occupied by SSH session async work,Wait()blocks indefinitely even though the TCS is logically complete.This replaces
TaskCompletionSource<bool>withManualResetEventSlim, which signals the waiter directly via kernel event — zero thread pool dependency. The test logic and race setup are unchanged; it still deterministically validates the deadlock fix on both .NET 8 and .NET Framework 4.8.