Skip to content

Switch ESRP service connection to wif2 for fix ADO npm publish #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpablo2002 merged 2 commits into from
Jul 28, 2026
+5 −4
Merged

Switch ESRP service connection to wif2 for fix ADO npm publish #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
554eacb
Switch ESRP service connection to wif2 for ADO agent v5 compatibility
juanpacostaaa Jul 27, 2026
8ec3b6f
Use dedicated thread instead of Task.Run in deadlock test to avoid th…
juanpacostaaa Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pipelines/dev-tunnels-ssh-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ jobs:
- task: EsrpRelease@11
condition: and(succeeded(), eq('${{ parameters.PublishNpmPackage }}', 'true'))
inputs:
connectedservicename: 'Devtunnels-esrp-ame-msi'
connectedservicename: 'Devtunnels-esrp-ame-msi-wif2'
usemanagedidentity: true
keyvaultname: 'tunnels-ppe-esrp-kv'
signcertname: 'esrp-sign'
Expand Down
7 changes: 4 additions & 3 deletions test/cs/Ssh.Test/ChannelTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,10 @@ private static Action InstallOpenCancelRaceHook(
cancellationSource.Token.Register(
() => callbackStarted.TrySetResult(true));

// Cancel on a background thread. Cancel() invokes all registered
// callbacks sequentially on its thread before returning.
Task.Run(() => cancellationSource.Cancel());
// Cancel on a dedicated thread (not the thread pool, which can be
// starved under CI load). Cancel() invokes all registered callbacks
// sequentially on this thread before returning.
new Thread(() => cancellationSource.Cancel()) { IsBackground = true }.Start();

// Wait for a monitoring callback to fire. Since Cancel() executes
// callbacks sequentially, the internal callback starts immediately
Expand Down
Loading