Skip to content

Dev/sraroseck/danmoseley/binskim suppress err997 ilonly #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sasinkas wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Dev/sraroseck/danmoseley/binskim suppress err997 ilonly #1193

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
960b47d
Suppress ERR997 for IL-only managed assemblies
Apr 16, 2026
4273557
Replace EnforcePdbLoadForManagedAssemblies with RequiresPdbForManaged…
Apr 18, 2026
a27d1da
Refactor: fold IsManagedResourceOnly into targetRequiresPdb local
Apr 18, 2026
5b10cf3
Revert API rename: keep EnforcePdbLoadForManagedAssemblies, default t…
Apr 20, 2026
63ff910
Simplify: inline condition instead of targetRequiresPdb local
Apr 20, 2026
324b282
Fix doc comment: remove inaccurate IL-only claim
Apr 20, 2026
2d03f4e
Merge branch 'main' into binskim-suppress-err997-ilonly
Sasinkas May 18, 2026
3250a8f
Merge pull request #1174 from danmoseley/binskim-suppress-err997-ilonly
Sasinkas Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/BinSkim.Rules/PERules/WindowsBinaryAndPdbSkimmerBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public abstract class WindowsBinaryAndPdbSkimmerBase : WindowsBinarySkimmerBase
/// managed and native code require PDBs for the native case but not
/// for managed.
/// </summary>
public virtual bool EnforcePdbLoadForManagedAssemblies => true;
public virtual bool EnforcePdbLoadForManagedAssemblies => false;

public virtual bool LogPdbLoadException => true;

Expand All @@ -50,6 +50,7 @@ public sealed override void Analyze(BinaryAnalyzerContext context)
if (LogPdbLoadException)
{
if (target.Pdb == null &&
!target.PE.IsManagedResourceOnly &&
(!target.PE.IsManaged ||
target.PE.IsMixedMode ||
EnforcePdbLoadForManagedAssemblies))
Expand Down
Loading