Dev/sraroseck/draft/update tests/unit tests/dwarf attribute value#1171
Open
Sasinkas wants to merge 42 commits into
Open
Dev/sraroseck/draft/update tests/unit tests/dwarf attribute value#1171Sasinkas wants to merge 42 commits into
Sasinkas wants to merge 42 commits into
Conversation
… data reading behavior
…d line info extraction
…arfAttributeValue
…tails; add helper methods for DWARF line number program tests
- Created Test.IntegrationTests.BinSkim.Driver project and added to solution - Implemented BinSkimRunner to launch BinSkim as an external process - Added AnalyzeCommandIntegrationTests with 5 passing tests for self-scan and command line options
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…arfAttributeValue
- Introduced Managed_netcoreapp3.1_portable_exe_sha1.pdb to support secure source code hashing tests. - Added Managed_netstandard2.0_portable_sha1.dll and its corresponding PDB file for .NET Standard 2.0 to enhance testing capabilities.
…arfAttributeValue
…ot finder, and update project configuration
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…arfAttributeValue
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…eValue' of https://github.com/microsoft/binskim into dev/sraroseck/draft/UpdateTests/UnitTests/DwarfAttributeValue
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…arfAttributeValue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
DwarfLineNumberProgram.cs — Fixed off-by-one error in directory index bounds check (<= directories.Count - 1 → <= directories.Count)
New Integration Test Project
Test.IntegrationTests.BinSkim.Driver (new project added to solution)
BinSkimRunner.cs — Test harness that launches BinSkim as an external process, captures exit code/stdout/stderr/SARIF output
AnalyzeCommandIntegrationTests.cs — End-to-end integration tests for the analyze command
BinSkim.Integration.Tests.ps1 — PowerShell/Pester-based integration tests
New Unit Tests (Dwarf/ELF)
DwarfAttributeValueTests.cs — Tests for DWARF attribute value parsing
DwarfCommonInformationEntryTests.cs — Tests for CIE (Common Information Entry) parsing
DwarfCompilationUnitFormTests.cs — Extended tests for compilation unit form handling
DwarfFrameDescriptionEntryTests.cs — Tests for FDE (Frame Description Entry) parsing
DwarfLineNumberProgramTests.cs — Tests for line number program logic (relates to the bug fix)
DwarfSymbolProviderTests.cs — Tests for the DWARF symbol provider
DwarfSymbolTests.cs — Tests for DWARF symbol parsing
DwarfTestHelpers.cs — Shared test helper utilities
ElfBinaryTests.cs — Tests for ELF binary parsing
Test Reorganization
RuleTests.cs — Refactored (440 lines changed, likely reducing noise / restructuring)
Test sample files moved into Error/ and Warning/ subdirectories for clearer categorization of expected results (SHA1-related test binaries)
Build/Infra
BuildPackages.cmd — Defaults Configuration to Release if not set
BinSkim.sln — Added the new integration test project