Skip to content

Fix pch file name option format in EnableSecureSourceCodeHashing rule #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sasinkas wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix pch file name option format in EnableSecureSourceCodeHashing rule #1092

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a799cdd
Fix pch file name option format in EnableSecureSourceCodeHashing rule
Sasinkas Aug 19, 2025
6407b48
Merge branch 'main' into users/sraroseck/FpFlag
Sasinkas Aug 19, 2025
cd594be
Merge branch 'main' into users/sraroseck/FpFlag
Sasinkas Apr 7, 2026
d4f291c
Merge branch 'main' into users/sraroseck/FpFlag
Sasinkas Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BinSkim.Rules/PERules/BA2004.EnableSecureSourceCodeHashing.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public void AnalyzeNativeBinaryAndPdb(BinaryAnalyzerContext context)
if (omDetails.GetOptionValue(pchOptionSwitches, OrderOfPrecedence.FirstWins, ref pchHeaderFile) == true)
{
// Now check to see if a pch file name was specified using /Fp:
string[] pchFileNameOptions = { "/Fp:" };
string[] pchFileNameOptions = { "/Fp" };
if (omDetails.GetOptionValue(pchFileNameOptions, OrderOfPrecedence.FirstWins, ref pchFileName) != true)
{
// no pch filename specified, so the filename defaults to the pchHeaderFile with the extension swapped to ".pch"
Expand Down
Loading