test: add UTF-8 encoding regression tests (#5566)#7880
Open
hsms4710-pixel wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds comprehensive regression tests to prevent future encoding issues in AutoGen (Issue #5566).
After the fix for #5566 was merged, there were no tests to prevent regression. If someone accidentally removes
encoding="utf-8"in the future, the bug will return. These tests catch that.Related issue number
Fixes #5566
Checks
I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://github.com/microsoft/autogen/blob/main/CONTRIBUTING.md to build and test documentation locally.
I've added tests corresponding to the changes introduced in this PR.
I've made sure all auto checks have passed.
📝 Description
This PR adds comprehensive regression tests to prevent future encoding issues in AutoGen.
Changes
test_encoding.pywith 5 test casesencodingparameterspage_script.jsUTF-8 validityTesting
Why This Matters
After the fix for #5566 was merged, there's no test to prevent regression.
If someone accidentally removes
encoding="utf-8"in the future,the bug will return. These tests catch that.
🧪 Test Coverage
✅ Checklist