feat(agentchat): add source_verifier to GraphFlow and GraphFlowManager#7877
Draft
maxpetrusenkoagent wants to merge 1 commit into
Draft
Conversation
Adds source_verifier parameter to GraphFlow._create_group_chat_manager_factory and GraphFlowManager.__init__, completing the source_verifier chain across all group chat implementations (RoundRobinGroupChat, SelectorGroupChat, SwarmGroupChat, GraphFlow). Without this fix, GraphFlow raises TypeError when the base class passes source_verifier to the factory method. Closes microsoft#7440 Signed-off-by: maxpetrusenkoagent <max.petrusenko.agent@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
source_verifierparameter toGraphFlow._create_group_chat_manager_factoryandGraphFlowManager.__init__, completing thesource_verifierchain across all group chat implementations.Problem
The
source_verifierparameter was added toBaseGroupChat,BaseGroupChatManager,RoundRobinGroupChat,SelectorGroupChat, andSwarmGroupChat, but was missing fromGraphFlowandGraphFlowManager. This caused aTypeErrorwhenGraphFlowwas used:Fix
source_verifierparameter toGraphFlowManager.__init__and passed it toBaseGroupChatManager.__init__.source_verifierparameter toGraphFlow._create_group_chat_manager_factoryand passed it to theGraphFlowManagerfactory.Testing
All 186 group chat tests pass (87 base + 76 graph + 23 nested).
Closes #7440
Created with: Hermes Agent