Skip to content

fix(docker-jupyter): restrict bind directory to 0o700 #7872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camgrimsec wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(docker-jupyter): restrict bind directory to 0o700 #7872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion python/packages/autogen-ext/src/autogen_ext/code_executors/docker_jupyter/_jupyter_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,11 @@ def __init__(
if bind_dir:
self._bind_dir = Path(bind_dir) if isinstance(bind_dir, str) else bind_dir
self._bind_dir.mkdir(exist_ok=True)
os.chmod(bind_dir, 0o777)
# Owner-only (0o700). Docker bind-mount preserves ownership, so the
# container retains read/write regardless of host-side mode. 0o777
# unnecessarily exposed agent-generated code and session artifacts to
# any local user on the host.
os.chmod(bind_dir, 0o700)

# Determine and prepare Docker image
image_name = custom_image_name or "autogen-jupyterkernelgateway"
Expand Down