Fix HTML validation issues in index.html#1802
Open
vedparkasharya wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix HTML validation issues in index.html#1802vedparkasharya wants to merge 1 commit intomicrosoft:mainfrom
vedparkasharya wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two HTML quality issues in
index.html:1. Fixed invalid HTML structure
The Google Fonts
<link>tag was placed before<!DOCTYPE html>, which is invalid HTML. According to the HTML5 specification, content must appear within the<html>element, and external resource links like Google Fonts should ideally be in the<head>section.Before:
After:
2. Fixed protocol-relative URL
Changed
//cdn.jsdelivr.net/npm/docsify/lib/docsify.min.jstohttps://cdn.jsdelivr.net/npm/docsify/lib/docsify.min.js.Protocol-relative URLs (
//) were useful when both HTTP and HTTPS were common, but now they are considered an anti-pattern. They can cause issues on local files (file://) and mixed content warnings. Using explicithttps://is the modern best practice.Impact
Testing