Show mount progress phases in CLI during gvfs mount#2005
Open
tyrielv wants to merge 1 commit into
Open
Conversation
tyrielv
force-pushed
the
tyrielv/mount-progress
branch
from
febec85 to
7669cb3
Compare
Move the named pipe server start earlier in InProcessMount so
MountVerb can connect and poll status during the parallel
auth+validation phase. Add a MountProgress field to the GetStatus
response carrying a human-readable phase description that the CLI
renders as a dynamic spinner sub-status.
Changes:
- NamedPipeMessages: add MountProgress to GetStatus.Response
- InProcessMount: volatile progress string set at each phase;
pipe started after RepoMetadata init (before parallel tasks);
HandleRequest guards non-GetStatus during Mounting state;
HandleGetStatusRequest null-safe for early-pipe fields
- ConsoleHelper: new ShowStatusWhileRunning overloads accepting
Func<string> getMessage for dynamic spinner text
- GVFSEnlistment: optional Action<string> onProgress callback on
WaitUntilMounted (existing callers unaffected)
- MountVerb: wires dynamic spinner to progress callback
User sees: Mounting (Authenticating and validating)...
Mounting (Starting virtualization)...
Mounting...Succeeded
Assisted-by: Claude Opus 4.6
Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
tyrielv
force-pushed
the
tyrielv/mount-progress
branch
from
7669cb3 to
6af85b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Show detailed mount progress in the CLI during
gvfs mount. Previously users saw a single "Mounting..." spinner with no detail. Now the spinner updates with the current phase:Problem
After parallelizing pre-mount operations in InProcessMount (#1908), the named pipe server started late (after all validations complete), so MountVerb had less time to poll status. Even after pipe connect, GetStatus only returned "Mounting" with no sub-phase detail.
Changes
Protocol - Add
MountProgressstring toGetStatus.Response(backward compatible)InProcessMount (
GVFS.Mount)currentStatevolatile for correct cross-thread readsConsoleHelper (
GVFS.Common)ShowStatusWhileRunningoverloads acceptingFunc<string> getMessagefor dynamic spinner text with line-clearingGVFSEnlistment (
GVFS.Common)Action<string> onProgresscallback onWaitUntilMounted(default null, existing callers unaffected)MountVerb (
GVFS)Parallelism handling
The parallel phase (network auth + local validation) uses a single combined progress message set before
Task.Run, updated only afterTask.WaitAll. No per-task racing.Testing