Fix MIDIMessageEvent.data incorrectly typed as nullable#63395
Closed
Nedunchezhiyan-M wants to merge 1 commit intomicrosoft:mainfrom
Closed
Fix MIDIMessageEvent.data incorrectly typed as nullable#63395Nedunchezhiyan-M wants to merge 1 commit intomicrosoft:mainfrom
Nedunchezhiyan-M wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Collaborator
|
It looks like you've sent a pull request to update some generated declaration files related to the DOM. These files aren't meant to be edited by hand, as they are synchronized with files in the TypeScript-DOM-lib-generator repository. You can read more here. For house-keeping purposes, this pull request will be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60546
Summary
MIDIMessageEvent.datawas typed asUint8Array<ArrayBuffer> | nullafter a DOM update in #57027, but the Web MIDI API spec defines it as:The property is never
null— it always contains the MIDI data bytes of the event. This removes the erroneous| nullto match the spec and MDN documentation.Change
src/lib/dom.generated.d.ts:MIDIMessageEvent.datachanged fromUint8Array<ArrayBuffer> | null→Uint8Array<ArrayBuffer>AI Disclosure
This PR was developed with AI assistance (Claude Code). The fix was identified and verified manually against the Web MIDI API spec and MDN documentation.