Toolset update: MSVC Compiler 19.52.36405.1, Clang 22.1.3#6296
Open
StephanTLavavej wants to merge 39 commits into
Open
Toolset update: MSVC Compiler 19.52.36405.1, Clang 22.1.3#6296StephanTLavavej wants to merge 39 commits into
StephanTLavavej wants to merge 39 commits into
Conversation
For example, libcxx/test/std/algorithms/alg.nonmodifying/alg.equal/equal.pass.cpp has: ```cpp // We test the cartesian product, so we sometimes compare differently signed types // ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings): -Wno-sign-compare // ADDITIONAL_COMPILE_FLAGS(character-conversion-warnings): -Wno-character-conversion ```
LLVM-62096 was reportedly fixed in Clang 21, but I can't remove this workaround yet.
All positive except for `P0896R4_ranges_iterator_machinery` adding a space in `ranges::iter_move (&f)(42)`.
See GH 5717, warning C4127 was removed by MSVC-PR-646313 on 2025-06-25. The name `_Would_overflow` still provides value, keep it.
…wrapping. And split `static_assert(X && Y)`.
We're still customizing it, no behavior change.
This was unexpectedly passing for x86, but still failing for other architectures.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
zacklj89
approved these changes
May 21, 2026
Member
Author
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainas of 2026-05-06.__reference_{constructs,converts}_from_temporaryllvm/llvm-project#114344 was fixed in Clang 21.#__NoopCoro_ResumeDestroy(EC Symbol) llvm/llvm-project#158341 was fixed in Clang 22.__builtin_is_implicit_lifetimeisn't checking for trivial constructors llvm/llvm-project#160610 was fixed in Clang 22.tagged_bool_likefor Clang 22.-Wdeprecated-volatile.-Wcharacter-conversion, added in Clang 21.libcxx/test/std/algorithms/alg.nonmodifying/alg.equal/equal.pass.cpphas// ADDITIONAL_COMPILE_FLAGS(character-conversion-warnings): -Wno-character-conversion.reference_constructs_from_temporarymishandles cv-qualified arrays llvm/llvm-project#198580.flat_map::at()llvm/llvm-project#198663.P2278R4_views_as_const: Clang 22 emits error: satisfaction of constraint '__is_constructible(_Ty, _ArgTys...)' depends on itself #6295 for followup.P0896R4_ranges_iterator_machineryadding a space inranges::iter_move (&f)(42)._Diff_maxto avoid manual wrapping._Would_overflowstill provides value, keep it._Effective_maxfor clarity._Invoker1<_Callable, _Ty1>::_Strategyfor clarity._Valtyto avoid manual wrapping.static_assertmessages to avoid manual wrapping.static_assert(X && Y).0xprefix..clang-format: Update URL and defaults. No behavior changes..clang-format:AlignAfterOpenBracketis now a bool..clang-format: Sort<benchmark/benchmark.h>as the first group.robust_re_difference_type.compile.pass.cppas SKIPPED.STL-ASan-CI passed; it had been failing for ARM64 since the previous toolset update #6260 and is now fixed by @zacklj89's MSVC-PR-731943 "[ARM64][ASan] Fix interception in jump tables" merged 2026-04-27.