fix(line): prevent series color reset when switching to Granular mode#123
Open
ansaganie wants to merge 3 commits into
Open
fix(line): prevent series color reset when switching to Granular mode#123ansaganie wants to merge 3 commits into
ansaganie wants to merge 3 commits into
Conversation
Adds regression test: "should not reset the color of untargeted series when one series color is changed in Granular mode".
…set in Granular mode
…others Query the palette unconditionally for every line (override applied on top) instead of lazily, so changing one line's color no longer shifts the others. Drops the no-op clearContainers approach and rewrites the regression test to model a report reload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent series color reset when switching to Granular mode
Adds regression test: "should not reset the color of untargeted series when one series color is changed in Granular mode".