Added new warning icon for missing data#181
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new data gap detection feature to the Power BI Multi-KPI visual, allowing users to detect and display warnings about missing days in time-series data. The feature parallels the existing stale data functionality.
- Adds data gap detection with configurable warning messages
- Displays gap indicators in the subtitle section with tooltips
- Provides per-series gap information when multiple series have different gaps
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/dataGapDetector.ts | New utility class that detects gaps in time-series data and formats warning messages |
| src/settings/descriptors/dataGapDescriptor.ts | New settings descriptor for data gap configuration including colors and message template |
| src/converter/data/dataRepresentation.ts | Adds IDataGapInfo interface to store gap detection results |
| src/converter/data/dataConverter.ts | Integrates gap detection into data processing pipeline |
| src/visualComponent/subtitleWarningComponent.ts | Adds rendering logic for data gap warnings with tooltips |
| src/visualComponent/rootComponent.ts | Passes data gap settings to subtitle component |
| src/settings/settings.ts | Registers data gap descriptor in settings model |
| capabilities.json | Defines data gap properties in Power BI capabilities |
| styles/styles.less | Adds CSS styling for data gap icon |
| stringResources/en-US/resources.resjson | Adds localized strings for data gap feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Demonkratiy
left a comment
Demonkratiy
left a comment
There was a problem hiding this comment.
Thanks for the feature — the structure mirrors Stale Data nicely. A few things to address before merge: a JSON syntax error in the string resources, the gap icon currently being identical to the Stale Data icon, and a double-counting edge case in the gap detector. Details inline.
- Bump runner to ubuntu-latest and actions (checkout@v4, setup-node@v4) - Update Node matrix to 20.x/22.x, add npm cache - Reorder steps (ci before audit/outdated), drop dead eslint script - Add concurrency with cancel-in-progress - Add ChromeHeadlessCI launcher (--no-sandbox) for Ubuntu 24.04 sandbox
No description provided.