Make macOS CI runners opt-in via workflow_dispatch#1012
Open
Make macOS CI runners opt-in via workflow_dispatch#1012
Conversation
Remove macos-latest from the test-workspace and test-workspace-features OS matrices. Add dedicated test-workspace-macos and test-workspace-features-macos jobs that only run when the workflow is manually dispatched with run_macos: true. The new macOS jobs are intentionally excluded from the ci-gate required check so they never block merges. Fixes #843 Agent-Logs-Url: https://github.com/microsoft/DiskANN/sessions/e959ada8-d34c-4801-9a4c-27cb42d74e1d Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
harsha-simhadri
May 4, 2026 20:33
View session
…cate jobs Replace four separate test jobs with two that dynamically include macOS in the matrix only on workflow_dispatch with run_macos=true. Removes ~66 lines of duplication while preserving identical behavior. Agent-Logs-Url: https://github.com/microsoft/DiskANN/sessions/a6dea22b-fa87-4413-8639-083eb57c8e84 Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
harsha-simhadri
force-pushed
the
copilot/review-issue-844
branch
from
834cf9a to
9b2d6df
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1012 +/- ##
==========================================
- Coverage 89.55% 89.51% -0.04%
==========================================
Files 459 460 +1
Lines 85034 85424 +390
==========================================
+ Hits 76153 76469 +316
- Misses 8881 8955 +74
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes macOS CI runners opt-in by adding a workflow_dispatch input (run_macos) and conditionally including macos-latest in the test matrices only when the workflow is manually triggered with that input enabled.
Changes:
- Added
workflow_dispatchtrigger with a booleanrun_macosinput. - Updated
test-workspaceandtest-workspace-featuresjob matrices to include macOS only whenrun_macosis true on manual dispatch. - Added clarifying comments about macOS CI being opt-in.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
hildebrandmw
reviewed
May 6, 2026
Contributor
hildebrandmw
left a comment
hildebrandmw
left a comment
There was a problem hiding this comment.
This inline JSON ternary thing is not the best. What about this as an alternative?
test-workspace:
needs: basics
name: test workspace
if: ${{ matrix.os != 'macos-latest' || (github.event_name == 'workflow_dispatch' && inputs.run_macos) }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
os:
- windows-latest
- ubuntu-latest
- ubuntu-24.04-arm
- macos-latest # skipped unless manually triggered
hildebrandmw
approved these changes
May 8, 2026
metajack
approved these changes
May 8, 2026
harsha-simhadri
approved these changes
May 8, 2026
arrayka
reviewed
May 8, 2026
| branches: ["main"] | ||
| pull_request: | ||
| branches: ["main"] | ||
| workflow_dispatch: |
Contributor
There was a problem hiding this comment.
Why don't we just run macos after check-in (push event)?
We run miri-tests on post check-in: if: ${{ github.event_name == 'push' }}
arrayka
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make macOS CI runner opt-in since runners are slow to provision. When opted in, CI is still gated on macOS tests passing.