ci(prBuild): target 26100 SDK, and install the 26100 WDK#109
Merged
Conversation
Member
You'll need to add explicit CMake args to target the 22621 SDK. |
Collaborator
Author
I'd thought |
vdwtanner
force-pushed
the
user/tvandewalle/install-wdk-in-prbuild
branch
from
May 21, 2026 21:43
d34de5b to
39cb918
Compare
….hpp PR build was failing because windows-latest runners ship Windows SDKs (10.0.22621.0 and 10.0.26100.0) but no WDK. D3D12TranslationLayer's DxbcParser transitively includes d3d12TokenizedProgramFormat.hpp, which only ships with the WDK. Install the WDK matching CMAKE_SYSTEM_VERSION (10.0.22621.0) via winget (pre-installed on windows-latest). The 22621 WDK places its headers under the same Windows Kits\10\Include\10.0.22621.0 path the SDK uses, so CL picks them up with no extra include paths. The verification step asserts the expected header lands at the expected path, so a future winget package-id rename trips a clear failure instead of an opaque C1083. Resolves bug 58650349.
vdwtanner
force-pushed
the
user/tvandewalle/install-wdk-in-prbuild
branch
from
May 21, 2026 22:09
39cb918 to
3827e07
Compare
jenatali
approved these changes
May 21, 2026
jenatali
left a comment
jenatali
left a comment
Member
There was a problem hiding this comment.
We should fix the title/description
vdwtanner
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR build was failing because windows-latest runners ship Windows SDKs (10.0.22621.0 and 10.0.26100.0) but no WDK. D3D12TranslationLayer's DxbcParser transitively includes d3d12TokenizedProgramFormat.hpp, which only ships with the WDK.
Install the WDK matching CMAKE_SYSTEM_VERSION (10.0.22621.0) via winget (pre-installed on windows-latest). The 22621 WDK places its headers under the same Windows Kits\10\Include\10.0.22621.0 path the SDK uses, so CL picks them up with no extra include paths.
The verification step asserts the expected header lands at the expected path, so a future winget package-id rename trips a clear failure instead of an opaque C1083.
Resolves #97