Skip to content

[Quality Management] Init values in the test if there are two or more promoted quality results #8255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakovljevicDusan wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

[Quality Management] Init values in the test if there are two or more promoted quality results #8255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ps/W1/Quality Management/app/src/Configuration/Result/QltyResultConditionMgmt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ codeunit 20409 "Qlty. Result Condition Mgmt."
ToTestQltyIResultConditConf."Condition Description" := CopyStr(Condition, 1, MaxStrLen(ToTestQltyIResultConditConf."Condition Description"));
ToTestQltyIResultConditConf.Insert();
end else
if AlwaysUpdateExistingCondition or (OnlyOverwriteIfADefaultCondition and (ToTestQltyIResultConditConf.Condition in [QltyInspectionResult."Default Boolean Condition", QltyInspectionResult."Default Number Condition", QltyInspectionResult."Default Text Condition"])) then begin
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Upgrade} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Empty condition silently overwrites on upgrade

Adding '' to the in list means any existing record whose Condition field is blank will now be treated as a default and overwritten during configuration seeding — even if the blank value was intentionally left by a user or previous customization. This silent data mutation can occur on every upgrade run that calls this code path with OnlyOverwriteIfADefaultCondition = true.

Recommendation:

  • Confirm whether a blank Condition should truly be equated with the named default values. If so, document this assumption. If not, keep the guard to the three explicit default constants and handle blank conditions separately (e.g., only overwrite blank on fresh insert). At minimum, add a comment explaining why '' is included alongside the named defaults.
Suggested change
if AlwaysUpdateExistingCondition or (OnlyOverwriteIfADefaultCondition and (ToTestQltyIResultConditConf.Condition in [QltyInspectionResult."Default Boolean Condition", QltyInspectionResult."Default Number Condition", QltyInspectionResult."Default Text Condition"])) then begin
if AlwaysUpdateExistingCondition or
(OnlyOverwriteIfADefaultCondition and
(ToTestQltyIResultConditConf.Condition in
// '' treated as uninitialized; safe to overwrite just like named defaults
['',
QltyInspectionResult."Default Boolean Condition",
QltyInspectionResult."Default Number Condition",
QltyInspectionResult."Default Text Condition"])) then begin

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why

if AlwaysUpdateExistingCondition or (OnlyOverwriteIfADefaultCondition and (ToTestQltyIResultConditConf.Condition in ['', QltyInspectionResult."Default Boolean Condition", QltyInspectionResult."Default Number Condition", QltyInspectionResult."Default Text Condition"])) then begin
ToTestQltyIResultConditConf.Validate(Condition, CopyStr(Condition, 1, MaxStrLen(ToTestQltyIResultConditConf.Condition)));
ToTestQltyIResultConditConf."Condition Description" := CopyStr(Condition, 1, MaxStrLen(ToTestQltyIResultConditConf."Condition Description"));
ToTestQltyIResultConditConf.Priority := QltyInspectionResult."Evaluation Sequence";
Expand Down
Loading