Skip to content

[Quality Management] Fix promoted-result matrix column visibility in pages #8252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakovljevicDusan wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Quality Management] Fix promoted-result matrix column visibility in pages #8252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c069af
Changes
JakovljevicDusan May 20, 2026
933172f
Implement code review suggestions
JakovljevicDusan May 20, 2026
2255e56
Revert changes
JakovljevicDusan May 20, 2026
5ac1845
Tooltip improvements
JakovljevicDusan May 20, 2026
90b70a3
Improve promoted result visibility
JakovljevicDusan May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 28 additions & 22 deletions ...ps/W1/Quality Management/app/src/Configuration/Result/QltyResultConditionMgmt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,30 +555,36 @@ codeunit 20409 "Qlty. Result Condition Mgmt."
QltyIResultConditConf.SetRange("Result Visibility", QltyIResultConditConf."Result Visibility"::Promoted);
QltyIResultConditConf.SetCurrentKey("Condition Type", "Result Visibility", Priority, "Target Code", "Target Re-inspection No.", "Target Line No.");
QltyIResultConditConf.Ascending(false);
if QltyIResultConditConf.FindSet() then

// Drive iteration by Qlty. Inspection Result using the same ordering and filters as
// GetDefaultPromotedResults so that a given "Result Code" always maps to the same Iterator slot.
QltyInspectionResult.SetRange("Result Visibility", QltyInspectionResult."Result Visibility"::Promoted);
QltyInspectionResult.SetCurrentKey("Result Visibility", "Evaluation Sequence");
QltyInspectionResult.Ascending(false);
if QltyInspectionResult.FindSet() then begin
Iterator := 0;
repeat
if QltyInspectionResult.Get(QltyIResultConditConf."Result Code") then begin
Iterator += 1;
if Iterator <= GetMaxResultConditions() then begin
MatrixVisibleStateToSet[Iterator] := true;
if QltyInspectionResult.Description <> '' then
MatrixArrayToSetCaptionSet[Iterator] := QltyInspectionResult.Description
else
MatrixArrayToSetCaptionSet[Iterator] := QltyInspectionResult.Code;
MatrixArrayToSetConditionCellData[Iterator] := QltyIResultConditConf.Condition;
MatrixArrayToSetConditionDescriptionCellData[Iterator] := QltyIResultConditConf."Condition Description";
if MatrixArrayToSetConditionDescriptionCellData[Iterator] = '' then
MatrixArrayToSetConditionDescriptionCellData[Iterator] := MatrixArrayToSetConditionCellData[Iterator];

if (not OptionalQltyInspectionHeader.IsTemporary()) and (OptionalQltyInspectionHeader."No." <> '') then
if MatrixArrayToSetConditionDescriptionCellData[Iterator].Contains('[') then
MatrixArrayToSetConditionDescriptionCellData[Iterator] := QltyExpressionMgmt.EvaluateTextExpression(MatrixArrayToSetConditionDescriptionCellData[Iterator], OptionalQltyInspectionHeader, OptionalQltyInspectionLine);

MatrixSourceRecordId[Iterator] := QltyIResultConditConf.RecordId();
end else
break;
Iterator += 1;
QltyIResultConditConf.SetRange("Result Code", QltyInspectionResult.Code);
if QltyIResultConditConf.FindFirst() then begin
MatrixVisibleStateToSet[Iterator] := true;
if QltyInspectionResult.Description <> '' then
MatrixArrayToSetCaptionSet[Iterator] := QltyInspectionResult.Description
else
MatrixArrayToSetCaptionSet[Iterator] := QltyInspectionResult.Code;
MatrixArrayToSetConditionCellData[Iterator] := QltyIResultConditConf.Condition;
MatrixArrayToSetConditionDescriptionCellData[Iterator] := QltyIResultConditConf."Condition Description";
if MatrixArrayToSetConditionDescriptionCellData[Iterator] = '' then
MatrixArrayToSetConditionDescriptionCellData[Iterator] := MatrixArrayToSetConditionCellData[Iterator];

if (not OptionalQltyInspectionHeader.IsTemporary()) and (OptionalQltyInspectionHeader."No." <> '') then
if MatrixArrayToSetConditionDescriptionCellData[Iterator].Contains('[') then
MatrixArrayToSetConditionDescriptionCellData[Iterator] := QltyExpressionMgmt.EvaluateTextExpression(MatrixArrayToSetConditionDescriptionCellData[Iterator], OptionalQltyInspectionHeader, OptionalQltyInspectionLine);

MatrixSourceRecordId[Iterator] := QltyIResultConditConf.RecordId();
end;
until (QltyIResultConditConf.Next() = 0) or (Iterator >= MaxResultConditions);
until (QltyInspectionResult.Next() = 0) or (Iterator >= MaxResultConditions);
end;
end;

local procedure GetMaxResultConditions(): Integer
Expand Down
16 changes: 8 additions & 8 deletions .../W1/Quality Management/app/src/Configuration/Template/QltyInspectionTemplateLine.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,21 +131,21 @@ table 20403 "Qlty. Inspection Template Line"
exit;

InitLineNoIfNeeded();
EnsureResultsExist(true);
Rec.CalcFields("Test Value Type");
end;

procedure InitLineNoIfNeeded()
var
ExistingsQltyInspectionTemplateLine: Record "Qlty. Inspection Template Line";
begin
if Rec."Line No." = 0 then begin
ExistingsQltyInspectionTemplateLine.SetRange("Template Code", Rec."Template Code");
ExistingsQltyInspectionTemplateLine.SetCurrentKey("Template Code", "Line No.");
ExistingsQltyInspectionTemplateLine.Ascending(false);
if ExistingsQltyInspectionTemplateLine.FindFirst() then;
Rec."Line No." := ExistingsQltyInspectionTemplateLine."Line No." + 10000;
end;
Comment thread
JakovljevicDusan marked this conversation as resolved.
if Rec."Line No." <> 0 then
exit;

ExistingsQltyInspectionTemplateLine.SetRange("Template Code", Rec."Template Code");
ExistingsQltyInspectionTemplateLine.SetCurrentKey("Template Code", "Line No.");
ExistingsQltyInspectionTemplateLine.Ascending(true);
if ExistingsQltyInspectionTemplateLine.FindLast() then;
Rec."Line No." := ExistingsQltyInspectionTemplateLine."Line No." + 10000;
end;

trigger OnModify()
Expand Down
Loading
Loading