EDocument: scope PEPPOL BIS 3.0 .xml file extension to correct document format#7913
Open
jeffreybulanadi wants to merge 1 commit into
Open
Conversation
…rmat The SetFileExt event subscriber in EDocImportPEPPOLBIS30.Codeunit.al unconditionally appended '.xml' to every E-Document Log export, regardless of the Document Format. This caused third-party integrations using a non-PEPPOL format (e.g., json, csv) to receive their exported files with an incorrect .xml extension. The subscriber now: - Only appends '.xml' when the E-Document Log entry has Document Format set to 'PEPPOL BIS 3.0' - Only appends '.xml' when the FileName has no extension already set, so that other subscribers or implementations can override it first No changes to behavior for PEPPOL BIS 3.0 documents when no extension has been set by another subscriber. Closes microsoft#7200
github-actions
Bot
added
AL: Apps (W1)
Groenbech96
approved these changes
May 8, 2026
Contributor
Groenbech96
left a comment
Groenbech96
left a comment
There was a problem hiding this comment.
You have build errors. My guess is import statements.
JesperSchulz
approved these changes
May 11, 2026
Contributor
|
Build fails with:
|
Contributor
|
Re-running build. |
Contributor
|
Pull latest main into branch. |
Contributor
|
@copilot merge main into the branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7200
The SetFileExt event subscriber in EDocImportPEPPOLBIS30.Codeunit.al (codeunit 6166) was unconditionally appending '.xml' to every E-Document Log export, regardless of the Document Format on the E-Document Service. This caused third-party integrations using non-PEPPOL formats (e.g., json, csv) to receive exported files with an incorrect .xml extension.
Root cause
The subscriber appended '.xml' for all Document Formats, not only PEPPOL BIS 3.0.
Change
The subscriber now guards with two conditions before appending '.xml':
No breaking changes
Fixes AB#634372