Skip to content

Add script for classification analysis of BBBC021 dataset after feature reduction#15

Open
DragaDoncila wants to merge 4 commits into
microscopium:masterfrom
DragaDoncila:classification-analysis
Open

Add script for classification analysis of BBBC021 dataset after feature reduction#15
DragaDoncila wants to merge 4 commits into
microscopium:masterfrom
DragaDoncila:classification-analysis

Conversation

@DragaDoncila

Copy link
Copy Markdown

No description provided.

Comment thread bbbc021_classification_analysis.py Outdated
cnf_matrix = confusion_matrix(y, y_pred)
np.set_printoptions(precision=2)

# Plot confusion matrix

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are large blocks of commented out code here. Is that because they are incorrect/buggy (and should be deleted), or because they are optional (and should be made into functions instead)?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are optional, and should be functions instead

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to bundle them up into functions then? Thanks for submitting the PR!

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, can do, but not until Friday at the earliest sorry!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no rush, you don't have to be sorry. It's certainly not holding anything else up, this is very self contained.

all_names_montage.extend(names_montage)
run_montage(sorted_filenames, names_montage)

## run features on images

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this section commented out?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once each section of the code was run, we commented out to speed things up. In a situation where you're running on a raw unprocessed directory, you'd need every part uncommented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants