Add support for GitHub Enterprise Server and GitHub AE#70
Open
some-natalie wants to merge 4 commits into
Open
Conversation
Author
|
@micnncim gentle bump on boring PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋🏻 Hello! This PR should fix #63 and also add support for GitHub AE. These two products use a different API endpoint than GitHub.com, but the functionality of the API is the same here.
To solve this, the
GITHUB_API_URLenvironment variable from the Actions runner is also picked up and shoved into the GitHub client. I used theNewEnterpriseClientfunction fromgo-github, which is a wrapper that specifies the API url in addition to the HTTP client (link). It still works exactly as expected for ALL github.com plans, as seen in my free-tier fork of this repo in the run here.I've also got it working exactly as expected in GitHub Enterprise Server, as seen in the screenshot below. (side note - sorry for the screenshots, but I don't have anything publicly accessible to show off here)